Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explorer] Prevents collision when owned object has more text #4529

Merged
merged 3 commits into from
Sep 13, 2022

Conversation

apburnie
Copy link
Contributor

@apburnie apburnie commented Sep 8, 2022

The Problem

The problem is that when the owned objects have long pieces of summary text, this text collides. This can be seen here: https://explorer.devnet.sui.io/addresses/0x9b598c9c5f28c94a660d3cbc047f67a510a60e7a

image

The Solution in Action

With longer text

image
image

With shorter text

image
image

@apburnie apburnie marked this pull request as ready for review September 8, 2022 19:06
Copy link
Collaborator

@mystie711 mystie711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andrew47 in addition to adding details for rules (max line of text to show) i have also added details for small screen size breakpoints in this Figma here,
https://www.figma.com/file/kSD0qXCIDZA4KQVNepA5hR/02-Explorer?node-id=204%3A48379

@apburnie
Copy link
Contributor Author

Following the updated Figma Design, how the problem of collision is met has has been updated to now add an ellipsis when text overruns 3 lines.

The below screenshot was captured on Mozilla Firefox, but the effect is the same on Google Chrome, Microsoft Edge and Safari:

image

Copy link
Collaborator

@mystie711 mystie711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much better @Andrew47 . May I request a few more tweaks to improve the layout,

  • padding between columns -> 40px
  • empty placeholder asset when we don’t have an image -> use the assets with the image icon in Figma
  • padding between image and text should be 15 (looks a lot more in the screenshot attached to task)
  • space between items on mobile - let’s update it to 10px (new request)

@mystie711
Copy link
Collaborator

Totally lost track of plot. this task is not meant for the updates in my last comment.
will file a new task for it. Please ignore my comments above.

@apburnie apburnie merged commit 6edfdb9 into main Sep 13, 2022
@apburnie apburnie deleted the OwnedObjectCollisionPrevent branch September 13, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants