wallet-ext: display non-transferable nfts #4784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchrysochoidis
requested review from
Jibz1,
gegaowp,
mystie711 and
Jordan-Mysten
|
💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3135108304#artifacts |
Jibz1
reviewed
Sep 26, 2022
pchrysochoidis
force-pushed
the
pc-wallet-ext-4676-show-non-transferable-nfts
branch
from
95a1d13
to
f6e0c80
Compare
Jordan-Mysten
approved these changes
Sep 26, 2022
|
|
pchrysochoidis
force-pushed
the
pc-wallet-ext-4676-show-non-transferable-nfts
branch
from
303b9c2
to
3813e87
Compare
Jordan-Mysten
approved these changes
Sep 26, 2022
kchalkias
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
Thanks @pchrysochoidis, PR behavior is aligned with what we agreed last week.
* allow nfts with `has_public_transfer` being false * disable send button when nft is not transferable * display NO MEDIA placeholder for nfts that don't have known media field * show object id when nft doesn't have a known name field
* add nft-type-image
* max length to 10 with max 6 chars prefix (default case for object ids)
* new background and icon * show tooltip only when hovering above the icon * wide view display `No media` as file type
pchrysochoidis
force-pushed
the
pc-wallet-ext-4676-show-non-transferable-nfts
branch
from
3813e87
to
48190f2
Compare
pchrysochoidis
deleted the
pc-wallet-ext-4676-show-non-transferable-nfts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
has_public_transferbeing falsefixes: #4676