Add staking types sdk #7389
Merged
Add staking types sdk #7389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Jibz1
force-pushed
the
add-staking-types-sdk
branch
from
3b190b5
to
a43e62a
Compare
666lcz
approved these changes
Jan 13, 2023
| @@ -737,4 +739,36 @@ export class JsonRpcProvider extends Provider { | |||
| ); | |||
| } | |||
| } | |||
|
|
|||
| async getDelegatedStake(address: string): Promise<DelegatedStake[]> { | |||
There was a problem hiding this comment.
Suggested change
| async getDelegatedStake(address: string): Promise<DelegatedStake[]> { | |
| async getDelegatedStake(address: SuiAddress): Promise<DelegatedStake[]> { |
|
|
||
| async getDelegatedStake(address: string): Promise<DelegatedStake[]> { | ||
| try { | ||
| const resp = await this.client.requestWithType( |
There was a problem hiding this comment.
Could you add a check for the address? Example: https://github.com/MystenLabs/sui/blob/a43e62a3ca6fc46a980faee5967e6f7628a2910a/sdk/typescript/src/providers/json-rpc-provider.ts#L295
| return resp; | ||
| } catch (err) { | ||
| throw new Error( | ||
| `Error dry running transaction with request type: ${err}` |
There was a problem hiding this comment.
Suggested change
| `Error dry running transaction with request type: ${err}` | |
| `Error in getDelegatedStake: ${err}` |
| return resp; | ||
| } catch (err) { | ||
| throw new Error( | ||
| `Error dry running transaction with request type: ${err}` |
There was a problem hiding this comment.
Suggested change
| `Error dry running transaction with request type: ${err}` | |
| `Error in getValidators: ${err}` |
Jibz1
force-pushed
the
add-staking-types-sdk
branch
from
b41d0fd
to
553b3ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Validator Type and RPC endpoint for getDelegatedStake and getValidators