Reversions #1
Closed
Reversions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment.' from MythTV/mythtv@d27bedf Fixed 6 months later in FFmpeg (a decade ago): Fix dvb subtitle decoding when display segment is missing. FFmpeg@7df9937
this quiets a warning about it being redefined elsewhere in ffmpeg
seems to have been added during an ffmpeg merge, but is unused
This is from 2010-08-24: detect available SIMD extensions when runtime-cpudetect is enabled MythTV/mythtv@2069741 but if you look at the following lines, ffmpeg has effectively the same since 2012-11-18: pp: add auto detection cpu flag. FFmpeg@59d686f
if ffmpeg doesn't need this, neither do we
from: MythTV/mythtv@68ca96c duplicates the condition on line 919, which will catch it and return
class: C++ keyword, but MythTV does not include this file removed parentheses resulted from a complier warning about "unnecessary parentheses"
Note: most of the defines aren't actually used
This reverts commit 1711295. The warnings are now suppressed in the files that include the internal headers.
This reverts commit 18cc06c.
This reverts commit 26f1bbd.
This reverts commit e70a6c0.
TODO: rename, probably to IVTV_VBI_CAPTION, add decoder so it is not DATA
TODO: how does this differ from AV_CODEC_ID_DVB_TELETEXT?
This reverts commit fd66eb8. See MythTV/mythtv#416 These changes are no longer need in MythTV.
This reverts commit 346d4db. from: changed: allow 4 second skew between streams in mov before attempting to seek MythTV/mythtv@e4170c6 No reason given for the change.
This reverts commit 9632275. I agree with stuartm’s decade old comment on MythTV ticket 3001: H.263 is not a commonly used codec and if these are still bugs, they should be (re-)opened upstream with FFmpeg. For frame rate “fix” see: October 2005 Closes #509, by applying patch. MythTV/mythtv@f851316 however, it has been wrong since October 2014: Merge commit '7ea1b3472a61de4aa4d41b571e99418e4997ad41' FFmpeg@17085a0 lavc: deprecate the use of AVCodecContext.time_base for decoding FFmpeg@7ea1b34 ----- for not compiled section see: Revert [25805], the fix for our workaround created playback problems MythTV/mythtv@eaa8f0d nuv: fix mpeg4 decoding issue in #3001 properly MythTV/mythtv@8082c91 MPEG-4 decode errors as of [12645] https://code.mythtv.org/trac/ticket/3001 Trunk unable to playback MPEG4 files created by mythtranscode https://code.mythtv.org/trac/ticket/8927
This reverts commit 6c8c380. from 2007-05-28: MythTV/mythtv@ef017db references: https://code.mythtv.org/trac/ticket/2972
…t_media_type_string
st->codec is deprecated and appears to be unused in the guarded code st should be non-null based on the for loop condition
…cket_unref" This reverts commit b591826, which caused skipping to fail when playing from the video library.
This reverts commit 066a086.
originally from MythTV/mythtv@3539d58 NB: mythtv/libs/libmythtv/decoders/avformatdecoder.cpp also needs to be updated
working toward merging utils-mythtv.c back into utils.c
FFmpeg 5.0 renames and exports this as ff_flush_packet_queue(). This change is intended to make transitioning to FFmpeg 5.0 easier. Technically, this should be in libavformat/internal.h, but, since it is currently unmodified, libavformat/avformat.h will work for now. (MythTV does not directly use this function.)
…find_stream_info()
st is a pointer not an unsigned int.
The warning was:
libavformat/mpegts-mythtv.c: In function ‘pmt_cb’:
libavformat/mpegts-mythtv.c:1971:14: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
1971 | tmp0 = avctx->cur_pmt_sect;
| ^
This is intended to make copying over the current FFmpeg mpegts.c produce a better diff. No functional change.
originally from MythTV/mythtv@0bc1604 referencing https://code.mythtv.org/trac/ticket/8260 References MythTV/mythtv#428 If this causes an issue, a new ticket with logs and a sample should be openned.
This change has been unnecessary since 3d21dadbc797298df112aa0838125c7b3ab384f9.
ulmus-scott
force-pushed
the
reversions
branch
from
cc0718d
to
989e1b5
Compare
Merged
|
Closing this because it is replaced by #2 |
ulmus-scott
pushed a commit
to ulmus-scott/FFmpeg
that referenced
this pull request
Aug 22, 2022
davs2_decoder_close doesn't free those on the fly frames which
don't get output yet. It's a design bug, but easy to workaround.
Before the patch:
Direct leak of 1198606 byte(s) in 2 object(s) allocated from:
#0 0x563af5e1e5f0 in malloc (ffmpeg+0x6675f0)
MythTV#1 0x563af9765ef3 in davs2_malloc davs2/source/common/common.h:1240
MythTV#2 0x563af9765ef3 in davs2_alloc_picture davs2/source/common/header.cc:815
Indirect leak of 3595818 byte(s) in 6 object(s) allocated from:
#0 0x563af5e1e5f0 in malloc (ffmpeg+0x6675f0)
MythTV#1 0x563af9765ef3 in davs2_malloc davs2/source/common/common.h:1240
MythTV#2 0x563af9765ef3 in davs2_alloc_picture davs2/source/common/header.cc:815
Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bennettpeter Equivalent to the changes in MythTV/mythtv#416