Negative random value where positive value is required

The function MythRandom(), introduced in commit 31a811e,
does create a 32-bit random value which is returned in an uint32_t.
This new function does replace the Linux system call random() which returns an int.
Note that int value returned by random() is always positive.
In places where an int is required the output of MythRandom() is cast to an int.
This value can however be negative and will be approximately 50% of the times it is called.
This is now fixed in the places where it had not been fixed alreay.

mythtv/libs/libmythfreemheg/Programs.cpp

@@ -319,7 +319,7 @@ void MHResidentProgram::CallProgram(bool fIsFork, const MHObjectRef &success, co
             {
                 int nLimit = GetInt(args.GetAt(0), engine);
                 MHParameter *pResInt = args.GetAt(1);
-                int r = static_cast<int>(MythRandom()) % (nLimit + 1);
+                int r = static_cast<int>(MythRandom() % (nLimit + 1));
                 engine->FindObject(
                     *(pResInt->GetReference()))->SetVariableValue(r);
                 SetSuccessFlag(success, true, engine);

mythtv/libs/libmythupnp/ssdp.cpp

@@ -541,7 +541,7 @@ bool SSDP::ProcessSearchRequest( const QStringMap &sHeaders,
 
     nMX = (nMX > 120) ? 120 : nMX;
 
-    int nNewMX = (0 + (static_cast<int>(MythRandom()) % nMX)) * 1000;
+    int nNewMX = (0 + static_cast<int>(MythRandom() % nMX)) * 1000;
 
     // ----------------------------------------------------------------------
     // See what they are looking for...

mythtv/programs/mythfrontend/playbackbox.cpp

@@ -2254,7 +2254,7 @@ void PlaybackBox::playSelectedPlaylist(bool Random)
         QList<uint> tmp = m_playList;
         while (!tmp.isEmpty())
         {
-            uint i = static_cast<int>(MythRandom()) % tmp.size();
+            uint i = MythRandom() % tmp.size();
             m_playListPlay.append(tmp[i]);
             tmp.removeAll(tmp[i]);
         }

mythtv/programs/mythfrontend/videodlg.cpp

@@ -3197,7 +3197,7 @@ void VideoDialog::playVideoWithTrailers()
     while (!trailers.isEmpty() && i < trailersToPlay)
     {
         ++i;
-        QString trailer = trailers.takeAt(static_cast<int>(MythRandom()) % trailers.size());
+        QString trailer = trailers.takeAt(static_cast<int>(MythRandom() % trailers.size()));
 
         LOG(VB_GENERAL, LOG_DEBUG,
             QString("Random trailer to play will be: %1").arg(trailer));