Fix a couple memory leaks. cppcheck.

[cherry-picked from ca59bf3]
MythTV · Feb 11, 2012 · b5a557f · b5a557f
1 parent 231ed7a
commit b5a557f
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/mythtv/libs/libmyth/audiooutputdigitalencoder.cpp b/mythtv/libs/libmyth/audiooutputdigitalencoder.cpp
@@ -173,13 +173,18 @@ size_t AudioOutputDigitalEncoder::Encode(void *buf, int len, AudioFormat format)
                 QString("low mem, reallocating in buffer from %1 to %2")
                 .arg(in_size)
                 .arg(required_len));
-        if (!(in = (inbuf_t *)realloc(in, in_size, required_len)))
+        inbuf_t *tmp = reinterpret_cast<inbuf_t*>
+            (realloc(in, in_size, required_len));
+        if (!tmp)
         {
+            free(in);
+            in = NULL;
             in_size = 0;
             VERBOSE(VB_AUDIO, LOC_ERR +
                     "AC-3 encode error, insufficient memory");
             return outlen;
         }
+        in = tmp;
         in_size = required_len;
     }
     if (format != FORMAT_S16)
@@ -224,13 +229,18 @@ size_t AudioOutputDigitalEncoder::Encode(void *buf, int len, AudioFormat format)
                     QString("low mem, reallocating out buffer from %1 to %2")
                     .arg(out_size)
                     .arg(required_len));
-            if (!(out = (outbuf_t *)realloc(out, out_size, required_len)))
+            outbuf_t *tmp = reinterpret_cast<outbuf_t*>
+                (realloc(out, out_size, required_len));
+            if (!tmp)
             {
+                free(out);
+                out = NULL;
                 out_size = 0;
                 VERBOSE(VB_AUDIO, LOC_ERR +
                         "AC-3 encode error, insufficient memory");
                 return outlen;
             }
+            out = tmp;
             out_size = required_len;
         }
         int data_size = 0;