Skip to content

Commit

Permalink
Initialize the MythUIImage filename correctly
Browse files Browse the repository at this point in the history
Fixes #9634.  Fixes #9708.  Refs #9547.

If the filename does not start with "/", "http://", "https://" or "ftp://", then
the actual filename loaded is uninitialized.  It can be any random crap on the
stack.  I'm honestly surprised this worked at all :)

This may fix things for #9547 as well, and should be tested with that
scenario too.
(cherry picked from commit 2c7735e)
  • Loading branch information
Beirdo committed May 28, 2011
1 parent 9375ffb commit c321ee6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mythtv/libs/libmythui/mythuiimage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class ImageLoadThread : public QRunnable

void run()
{
QString tmpFilename;
QString tmpFilename = m_filename;
if ((m_filename.startsWith("/")) ||
(m_filename.startsWith("http://")) ||
(m_filename.startsWith("https://")) ||
Expand Down

0 comments on commit c321ee6

Please sign in to comment.