Skip to content

Commit

Permalink
Coverity: Cddb - Calling empty() without checking the result is point…
Browse files Browse the repository at this point in the history
…less. I strongly suspect the intent here was instead to call .clear() instead, before adding search results to the vector, so I've made that change.
  • Loading branch information
stuartm committed Jan 25, 2015
1 parent fa32183 commit d17266f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mythplugins/mythmusic/mythmusic/cddb.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ Cddb::Album::operator QString() const
// search local database for discID
bool Dbase::Search(Cddb::Matches& res, const Cddb::discid_t discID)
{
res.matches.empty();
res.matches.clear();
res.discID = discID;

if (CacheGet(res, discID))
Expand Down

0 comments on commit d17266f

Please sign in to comment.