Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wayland: Link to Wayland and include Qt private platform headers #218

Closed
mark-kendall opened this issue Sep 21, 2020 · 3 comments
Closed
Assignees
Labels
task:developer Developer Task version:master Master Development Branch
Milestone

Comments

@mark-kendall
Copy link
Member

Qt does not directly expose either the wl_compositor or wl_surface objects to clients. We need these if we are going to call Wayland api's for additional functionality.

Proposal:-

  • add a 'wayland-extras' option to configure (for the time being at least not enabled by default)
  • if enabled require Wayland and check for existence of Qt private headers (QPlatformNativeInterface)
  • update libmythui.pro to include Qt private headers

Refs #210 and #216

@mark-kendall mark-kendall added version:master Master Development Branch task:developer Developer Task labels Sep 21, 2020
@mark-kendall mark-kendall added this to the 32.0 milestone Sep 21, 2020
@mark-kendall mark-kendall self-assigned this Sep 21, 2020
@garybuhrmaster
Copy link
Contributor

Re: default to not enabled. It is not my call, but I admit that for purposes of certain packaging automation that I prefer that configure default to enabled for useful features with the option to disable on the configure command line and a test in configure that disables the functionality if the required headers are not available with a line in the configure results summary reporting the results. Similar to how the recent vulkan option/tests were added to configure. And, at least with the current project CI buildbot configuration, it is likely to get better build coverage as configure does not (currently) use enable overrides (except for symbol-visibility). I suspect that the annoying part will be determining what the various distros name the package with the private headers to add them to the appropriate ansible stanza(s) and test those.

@mark-kendall
Copy link
Member Author

Re: default to not enabled. It is not my call, but I admit that for purposes of certain packaging automation that I prefer that configure default to enabled for useful features with the option to disable on the configure command line and a test in configure that disables the functionality if the required headers are not available with a line in the configure results summary reporting the results.

The longer term intention is to enable by default. Just being cautious in the short term.

mark-kendall added a commit that referenced this issue Nov 16, 2020
- this looks for the wayland client libs and headers - which we need if
we are to access Wayland directly
- actual code to follow...

Refs #216 #218
mark-kendall added a commit that referenced this issue Nov 17, 2020
- Note: Requires Qt private headers that are not yet checked for in
configure
- new functionality not used yet

Refs #216 #218
mark-kendall added a commit that referenced this issue Nov 17, 2020
mark-kendall added a commit that referenced this issue Nov 17, 2020
- this should *help* with Wayland opacity issues but is not a complete
cure. Best case scenario; it also improves performance (as the
compositor knows it only needs to render the MythTV main window and
nothing else)

Refs #210 #216 #218
@mark-kendall
Copy link
Member Author

This is complete with the exception of handling Qt private header detection in configure - which I can't figure out yet - so leaving the default behavior to not enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task:developer Developer Task version:master Master Development Branch
Projects
None yet
Development

No branches or pull requests

2 participants