New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace CONFIG_DARWIN with Q_OS_DARWIN; update deprecated Q_OS_MAC and Q_OS_MACX #442
Conversation
Some of the macOS/Darwin conditional code probably needs to be tested to see if it is still needed, e.g. mythtv/mythtv/libs/libmyth/mythcontext.cpp Lines 286 to 289 in 991d0f4
|
Ignore 4c56a8b |
I like all the bits of this pull request, but it is a mashup of several unrelated things. Please refocus it specifically on the CONFIG_DARWIN-> Q_OS_DARWIN and similar directive changes like the linux->linux and "if x" to "if defined(x)". The change for reordering compat.h should be separate pull requests so it can have a proper discussion. I think it looks good, but I'd like to consider it separately from all the preprocessor directive changes. In the future, changes like cleaning up doxygen, removing XRANDR, removing mythio.h, deleting unused code in mythmusic, and removing the math checks from configure should all be separate pull requests. I cherry-picked them this time, and am currently running them through my build system. If there aren't any problems I'll push them in an hour or so. The change to httprequest.cpp should be enhanced to remove all references to USE_SETSOCKOPT and submitted as a separate pull. That code was all commented out by 9846f8f in 2014 and can be removed. Please don't gratuitously reorder the include file statements in the code. |
My goal was to reduce use of mythconfig.h. I was cleaning up the code as I saw it. I agree the pull requests could have been more focused.
I'll look into it.
See #447
Reordering the includes does serve a purpose; however, I agree they should probably be in a separate commit, maybe even a separate pull request. |
All of these should probably be moved into the signal handler in libmythbase
which is its current meaning. See: deprecated qt/qtbase@eb8216d current meaning: https://github.com/qt/qtbase/blame/9db7cc79a26ced4997277b5c206ca15949133240/src/corelib/global/qsystemdetection.h#L199
I just pushed a version of this without the include file reordering. |
Was part of #430
Added a few new commits regarding
linux
vs__linux__