cleanup configure

[ulmus-scott]

This should be a better way of setting the C++ optimization flag.

TODO

• Decide on a satisfactory resolution to configure does not set optimization flag in CXXFLAGS #406

[ulmus-scott]

Some of the macOS/Darwin conditional code probably needs to be tested to see if it is still needed, e.g.

mythtv/mythtv/libs/libmyth/mythcontext.cpp

Lines 286 to 289 in 991d0f4

	#ifdef Q_OS_MAC
	// Qt 4.4 has window-focus problems
	gCoreContext->OverrideSettingForSession("RunFrontendInWindow", "1");
	#endif

[garybuhrmaster]

Maybe I misinterpreted the discussion on IRC, but as I understand it, the plan was to transition the (legacy) configure (derived from the original ffmpeg configure) to CMAKE as soon as V32 is released. So unless this work is helping that transition, this seems to all just be rearranging the deck chairs on the Titanic.

[ulmus-scott]

The first few commits make setting the optimization flag easier.

Most of the rest of the commits are replacing defined macros from configure with Qt macros (and updating the Qt macros for Darwin/macOS).

git grep -nE "[^A-Z]ARCH_" -- :^platform/** :^*/FFmpeg/**
only in:
configure
libmpeg2 (which will be removed once mythtranscode is updated)

mythtv/libs/libmyth/audio/audiooutputbase.cpp:321:#if ARCH_ARM || defined(Q_OS_ANDROID)
mythtv/libs/libmythtv/mythavutil.cpp:204:#if ARCH_ARM
mythtv/libs/libmythtv/mythdeinterlacer.cpp:13:#if (HAVE_SSE2 && ARCH_X86_64)
mythtv/libs/libmythtv/mythdeinterlacer.cpp:18:#if ARCH_AARCH64
mythtv/libs/libmythtv/mythdeinterlacer.cpp:20:#elif ARCH_ARM
mythtv/libs/libmythtv/mythdeinterlacer.cpp:517:#if (HAVE_SSE2 && ARCH_X86_64) || HAVE_INTRINSICS_NEON
mythtv/libs/libmythtv/mythdeinterlacer.cpp:550:#if (HAVE_SSE2 && ARCH_X86_64)
mythtv/libs/libmythtv/mythdeinterlacer.cpp:605:#if (HAVE_SSE2 && ARCH_X86_64)
mythtv/libs/libmythtv/mythdeinterlacer.cpp:660:#if (HAVE_SSE2 && ARCH_X86_64) || HAVE_INTRINSICS_NEON
mythtv/libs/libmythtv/visualisations/goom/zoom_filter_xmmx.cpp:5:#if defined(MMX) && !defined(ARCH_X86_64)
mythtv/settings.pro:286:release:contains( ARCH_POWERPC, yes ) {

https://doc.qt.io/qt-5/qtglobal.html#Q_PROCESSOR_ARM no macro for aarch64, unfortunately.

git grep -nE "[^_A-Z]CONFIG_" -- :^platform/** :^*/FFmpeg/** very few unique defines
git grep -nE "HAVE_" -- :^platform/** :^*/FFmpeg/** not very many unique defines either

[ulmus-scott]

I will split this into a few orthogonal pull requests.

• configure: Rename lib…_external to system_lib… #441 configure: Rename lib…_external to system_lib…
• replace CONFIG_DARWIN with Q_OS_DARWIN; update deprecated Q_OS_MAC and Q_OS_MACX #442 replace CONFIG_DARWIN with Q_OS_DARWIN; update deprecated Q_OS_MAC and Q_OS_MACX
  • Rearranging compat.h #447 Rearranging compat.h
• Minor cleanup to audio code #443 Minor cleanup to audio code
  • C++17 __has_include (sort of...) and minor libmythfreemheg cleanup #455 has_include
  • enable -Wundef for C++ code #456 -Wundef
• Configure trim FFmpeg only stuff #445 Configure trim FFmpeg only stuff