C++17 __has_include (sort of...) and minor libmythfreemheg cleanup #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2022
ulmus-scott
changed the title
Programs.cpp needed reordering of includes for HAVE_GETTIMEOFDAY (-Wundef)
<sys/timeb.h> is unused <sys/time.h> is unconditionally included by mythchrono.h but not used directly <ctime> is used unconditionally
no symbols are used from either (myth)config.h or compat.h
<ctime> and "mythchrono.h" are no longer needed The QDateTime conversion in FormatDate was incorrect. fromMSecsSinceEpoch instead of fromSecsSinceEpoch However, no one must use FormatDate since that error is from 0d195a9 on 2020-07-02.
ulmus-scott
force-pushed
the
has_include
branch
from
2ed6082
to
f82bf95
Compare
This was referenced May 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit was originally part of #443 .
I had hoped this would be more focused and coherent, but it isn't really.