Skip to content

Commit

Permalink
Removing Nethrar and WXtreme support since they're extremely out-of-d…
Browse files Browse the repository at this point in the history
…ate.
  • Loading branch information
Rob Nelson committed Jan 29, 2012
1 parent 2494d05 commit 057da87
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 49 deletions.
4 changes: 4 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -60,21 +60,25 @@
<artifactId>LWC</artifactId>
<version>3.53</version>
</dependency>
<!--
<dependency>
<groupId>org.akrieger</groupId>
<artifactId>Nethrar</artifactId>
<version>2.0</version>
</dependency>
-->
<dependency>
<groupId>org.yi.acru.bukkit</groupId>
<artifactId>Lockette</artifactId>
<version>1.3.8</version>
</dependency>
<!--
<dependency>
<groupId>de.luricos.bukkit.WormholeXTreme</groupId>
<artifactId>Wormhole</artifactId>
<version>1.011</version>
</dependency>
-->
<dependency>
<groupId>me.taylorkelly</groupId>
<artifactId>bigbrother</artifactId>
Expand Down
11 changes: 3 additions & 8 deletions src/com/afforess/minecartmaniacore/MinecartManiaCore.java
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

import javax.persistence.PersistenceException;

import org.akrieger.Nethrar.NethrarMinecartTeleportEvent;
import org.bukkit.Bukkit;
import org.bukkit.World;
import org.bukkit.entity.Entity;
Expand All @@ -26,8 +25,6 @@
import com.afforess.minecartmaniacore.minecart.MinecartOwner;
import com.afforess.minecartmaniacore.world.Item;

import de.luricos.bukkit.WormholeXTreme.Wormhole.events.StargateMinecartTeleportEvent;

public class MinecartManiaCore extends JavaPlugin {

public static final MinecartManiaCoreListener listener = new MinecartManiaCoreListener();
Expand Down Expand Up @@ -242,11 +239,9 @@ public static boolean isLWCEnabled() {
}

public static void callEvent(final Event event) {
if (event instanceof NethrarMinecartTeleportEvent) {
listener.onNethrarEvent((NethrarMinecartTeleportEvent) event);
} else if (event instanceof StargateMinecartTeleportEvent) {
listener.onWormholeExtremeEvent((StargateMinecartTeleportEvent) event);
}
/*
* if (event instanceof NethrarMinecartTeleportEvent) { listener.onNethrarEvent((NethrarMinecartTeleportEvent) event); } else if (event instanceof StargateMinecartTeleportEvent) { listener.onWormholeExtremeEvent((StargateMinecartTeleportEvent) event); }
*/
//now everyone else goes
Bukkit.getServer().getPluginManager().callEvent(event);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,16 +1,7 @@
package com.afforess.minecartmaniacore.event;

import org.akrieger.Nethrar.NethrarMinecartTeleportEvent;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;

import com.afforess.minecartmaniacore.MinecartManiaCore;
import com.afforess.minecartmaniacore.minecart.MinecartManiaMinecart;
import com.afforess.minecartmaniacore.world.MinecartManiaWorld;

import de.luricos.bukkit.WormholeXTreme.Wormhole.events.StargateMinecartTeleportEvent;

public class MinecartManiaListener implements Listener {

public MinecartManiaListener() {
Expand Down Expand Up @@ -191,36 +182,9 @@ public void onMinecartMeetConditionEvent(final MinecartMeetsConditionEvent event
public void onMinecartPassengerEjectEvent(final MinecartPassengerEjectEvent event) {

}

@EventHandler(priority = EventPriority.NORMAL)
public void onWormholeExtremeEvent(final StargateMinecartTeleportEvent event) {
//Special case
if (MinecartManiaCore.isWormholeXTremeEnabled()) {
try {
final StargateMinecartTeleportEvent e = event;
final MinecartManiaMinecart oldMinecart = MinecartManiaWorld.getMinecartManiaMinecart(e.getOldMinecart());
oldMinecart.copy(e.getNewMinecart());
oldMinecart.kill(false);
return;
} catch (final Exception e) {
}
}
}

@EventHandler(priority = EventPriority.NORMAL)
public void onNethrarEvent(final NethrarMinecartTeleportEvent event) {
if (MinecartManiaCore.isNethrarEnabled()) {
try {
if (event instanceof NethrarMinecartTeleportEvent) {
final NethrarMinecartTeleportEvent e = event;
final MinecartManiaMinecart oldMinecart = MinecartManiaWorld.getMinecartManiaMinecart(e.getOldCart());
oldMinecart.copy(e.getNewCart());
oldMinecart.kill(false);
return;
}
} catch (final Exception e) {
}
}
}

/*
* @EventHandler(priority = EventPriority.NORMAL) public void onWormholeExtremeEvent(final StargateMinecartTeleportEvent event) { //Special case if (MinecartManiaCore.isWormholeXTremeEnabled()) { try { final StargateMinecartTeleportEvent e = event; final MinecartManiaMinecart oldMinecart = MinecartManiaWorld.getMinecartManiaMinecart(e.getOldMinecart()); oldMinecart.copy(e.getNewMinecart()); oldMinecart.kill(false); return; } catch (final Exception e) { } } }
*
* @EventHandler(priority = EventPriority.NORMAL) public void onNethrarEvent(final NethrarMinecartTeleportEvent event) { if (MinecartManiaCore.isNethrarEnabled()) { try { if (event instanceof NethrarMinecartTeleportEvent) { final NethrarMinecartTeleportEvent e = event; final MinecartManiaMinecart oldMinecart = MinecartManiaWorld.getMinecartManiaMinecart(e.getOldCart()); oldMinecart.copy(e.getNewCart()); oldMinecart.kill(false); return; } } catch (final Exception e) { } } }
*/
}

3 comments on commit 057da87

@akrieger
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nethrar isn't 'extremely out of date' - while the last commit was in late December, the fact is there haven't been any breaking changes to it since then, and due to having a full time job, I've forgotten to update the 'latest build' number on the forum thread / bukkitdev project page. I tested last night, everything still works fine with 1.1-R3. Do you mind re-adding Nethrar support?

@N3X15
Copy link
Owner

@N3X15 N3X15 commented on 057da87 Feb 2, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might. Having trouble getting sleep recently due to new dog being annoying, so once I get some coffee I'll see what I can do

@akrieger
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also just updated Nethrar to no longer use deprecated APIs before they become breaking changes, so it really is up to date now :) Thanks!

Please sign in to comment.