Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Duplicate" amiibo cards #42

Closed
DanTheMan827 opened this issue Jul 15, 2020 · 6 comments
Closed

"Duplicate" amiibo cards #42

DanTheMan827 opened this issue Jul 15, 2020 · 6 comments
Assignees

Comments

@DanTheMan827
Copy link
Contributor

If you list all of the amiibo in the Animal Crossing series for example you'll see four Isabelle cards all listed as "Isabelle" (there are other characters too), maybe those should be differentiated in some way?

Perhaps add a series number field to the data, or maybe as part of the name?

@N3evin
Copy link
Owner

N3evin commented Jul 15, 2020

I had fixed it and label additional name. Not only to Isabelle but to some other duplicated amiibos.

4bae126

@N3evin N3evin self-assigned this Jul 15, 2020
@N3evin N3evin closed this as completed Jul 15, 2020
@DanTheMan827
Copy link
Contributor Author

This is also a problem for the Animal Crossing figures as well, should they perhaps be listed under separate amiibo series?

On the animal crossing website, there are three Animal Crossing amiibo series listed:

  • Animal Crossing: New Leaf - Welcome amiibo
  • Animal Crossing (Cards)
  • Animal Crossing (Figures)

https://animal-crossing.com/amiibo/

@N3evin
Copy link
Owner

N3evin commented Jul 16, 2020

Don't have to, figures and cards already had their own fields. I had already added addition tags to those duplicated names.

Don't really need to be so complicated to the point to list their series. The database is kept simple. If they really wanna know the series just use the the image.

@DanTheMan827
Copy link
Contributor Author

DanTheMan827 commented Jul 16, 2020

I'm just saying if someone used the database to rename bin files into folders with the series name and the character name for the filename, there'd be name conflicts with the figures and the cards that don't have any tags.

Maybe it was never intended to be used in such a fashion, but I'm just bringing it to your attention.

@N3evin
Copy link
Owner

N3evin commented Jul 16, 2020

I'm just saying if someone used the database to rename bin files into folders with the series name and the character name for the filename, there'd be name conflicts with the figures and the cards that don't have any tags.

Maybe it was never intended to be used in such a fashion, but I'm just bringing it to your attention.

noted, but for now, I will just leave it as it is :)

@cheatfreak47
Copy link
Collaborator

just pointing out that it'd be best for anyone intending on using the database to rename amiibo bins should be including the full 16-digit ID in the filename if they really didn't want to have some duplicate names happening, although I am not against the idea of having series numbers, I think that'd be kinda annoying to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants