Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Corrected derived From implementation #2

Merged
merged 3 commits into from
May 4, 2024
Merged

fix: Corrected derived From implementation #2

merged 3 commits into from
May 4, 2024

Conversation

N4D1K-lgtm
Copy link
Owner

  • Fixed logical error in confgr_derive::convert, to allow the use of types that don't implement Default.
  • Added foreign.rs in tests to ensure the macro is compatible with non default types.
  • Updated readme to correctly list field type trait bounds. ie. Deserialize, Clone and Debug.

@N4D1K-lgtm N4D1K-lgtm added the bug Something isn't working label May 4, 2024
@N4D1K-lgtm N4D1K-lgtm self-assigned this May 4, 2024
N4D1K-lgtm
N4D1K-lgtm commented May 4, 2024
View reviewed changes
Copy link
Owner Author

@N4D1K-lgtm N4D1K-lgtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal change, don't have anyone else to review.

@N4D1K-lgtm N4D1K-lgtm merged commit 4676dee into master May 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@N4D1K-lgtm N4D1K-lgtm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@N4D1K-lgtm