Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jbrowse integration back as a option in settings.py #119

Merged
merged 2 commits into from May 7, 2018

Conversation

hsiaoyi0504
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Mar 23, 2018

Coverage Status

Coverage increased (+2.4%) to 40.22% when pulling a9098d1 on jbrowse_as_an_option into f178813 on master.

@codecov
Copy link

codecov bot commented Mar 23, 2018

Codecov Report

Merging #119 into master will decrease coverage by 4.71%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   52.42%   47.71%   -4.72%     
==========================================
  Files          72       69       -3     
  Lines        3151     3483     +332     
==========================================
+ Hits         1652     1662      +10     
- Misses       1499     1821     +322
Impacted Files Coverage Δ
blast/models.py 78.12% <100%> (+25%) ⬆️
blast/admin.py 77.08% <40%> (-2.04%) ⬇️
blast/tasks.py 66.66% <66.66%> (+52.45%) ⬆️
i5k/settings.py 93.4% <80%> (-0.85%) ⬇️
blast/tests.py 30.36% <92.85%> (ø)
filebrowser/templatetags/fb_tags.py 17.97% <0%> (-39.33%) ⬇️
filebrowser/templatetags/fb_versions.py 21.92% <0%> (-38.6%) ⬇️
filebrowser/views.py 18.42% <0%> (-37.18%) ⬇️
filebrowser/functions.py 29.44% <0%> (-27.23%) ⬇️
filebrowser/templatetags/fb_csrf.py 42.1% <0%> (-26.32%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f178813...a9098d1. Read the comment docs.

@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 23, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 24, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 24, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 24, 2018
@NAL-i5K NAL-i5K deleted a comment Mar 24, 2018
Copy link
Contributor

@ifishlin ifishlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good

Copy link
Contributor

@childers childers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes look fine.

@NAL-i5K NAL-i5K deleted a comment May 3, 2018
@childers childers merged commit 485dd57 into master May 7, 2018
@childers childers deleted the jbrowse_as_an_option branch May 7, 2018 18:21
@childers childers mentioned this pull request Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants