Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve front end #91

Merged
merged 6 commits into from
Feb 1, 2018
Merged

Improve front end #91

merged 6 commits into from
Feb 1, 2018

Conversation

hsiaoyi0504
Copy link
Member

@hsiaoyi0504 hsiaoyi0504 commented Jan 18, 2018

Create the PR first and look the status of the CI. To solve #36.

@codecov
Copy link

codecov bot commented Jan 18, 2018

Codecov Report

Merging #91 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   40.09%   40.09%           
=======================================
  Files          82       82           
  Lines        4287     4287           
=======================================
  Hits         1719     1719           
  Misses       2568     2568
Impacted Files Coverage Δ
i5k/settings.py 95.49% <ø> (ø) ⬆️
blast/views.py 19.1% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17b8663...00623de. Read the comment docs.

@NAL-i5K NAL-i5K deleted a comment Jan 18, 2018
@NAL-i5K NAL-i5K deleted a comment Jan 18, 2018
@hsiaoyi0504 hsiaoyi0504 changed the title Blast Improve Improve front end Jan 18, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0002%) to 38.5% when pulling 37c80a3 on blast-improve into 17b8663 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 20, 2018

Coverage Status

Coverage increased (+0.0002%) to 38.5% when pulling 37c80a3 on blast-improve into 17b8663 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 38.678% when pulling 6fbc703 on blast-improve into 17b8663 on master.

@coveralls
Copy link

coveralls commented Jan 20, 2018

Coverage Status

Coverage increased (+0.0002%) to 38.5% when pulling 6fbc703 on blast-improve into 17b8663 on master.

@coveralls
Copy link

coveralls commented Jan 20, 2018

Coverage Status

Coverage increased (+0.0002%) to 38.5% when pulling 37c80a3 on blast-improve into 17b8663 on master.

@hsiaoyi0504
Copy link
Member Author

Although it looks like codecov check failed, I think it's safe to merge this update.

@childers childers merged commit d9c0d5a into master Feb 1, 2018
@childers childers deleted the blast-improve branch February 1, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants