Fixes a bug in handling "Spam detected" messages #430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
error.rb
so that it handles error responses created by Gitlab.com's spam protectioncorrectly. The error message is nested in a slightly off way (I believe
this is a bug), causing the error message formatting code to blow up as
it tries to join a string.
I admit doing
[val].flatten
feels a bit hackish, but the alternative (nested ternaries) is also not pretty. :)