-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: release stac-browser and fixes #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include app context config for bootstrap qualifier.
A managed policy is needed for permission boundary
Include github action to be used for production deployment with `veda-deploy`
- Upgrade to github actions to resolve outdated node version warnings - Add cdk deploy output to file to resolve set-output warning - Conventional PR linter if not not updated: we may need to remove or replace if this [upgrade PR](CondeNast/conventional-pull-request-action#19) is not accepted. For now, there is a warning in the pr action about forcing linter to run on an upgraded node version. Parent issue NASA-IMPACT/veda-architecture#345
…r instances with a cloudfront
…nable deploying a stac browser for a stac-api with a custom subdomain
) ## What ### Added - Add [eoapi-cdk construct ](https://github.com/developmentseed/eoapi-cdk/tree/main)for deploying a [radiant earth stac-browser](https://github.com/radiantearth/stac-browser) - Supports stacks that are deployed with either a custom subdomain (i.e. `<stage>-stac.delta-backend.com`) or cloudfront with custom routes (i.e. `<cfdomain>.com/api/stac`). - Add a construct to provision a new s3 website if an existing bucket is not provided in configuration ### Changed - aws-cdk-lib(s) version update - routes construct updated to use the bucket from the new s3 website construct as origin (instead of just an existing bucket). - Docs updated > **Note 1.** There is a hack in the PR to work around a sequencing issue: neither the https app id nor the stac api construct url are available at the time that the eoapi-construct builds the stac-browser (i.e. this is not a valid url string for the stac catalog: `https://${Token[TOKEN.189]}.execute-api.uswest-2.amazonaws.com`). To work around this we are able to infer what the STAC catalog url will be based on configuration for the cloudfront or subdomain. > **Note 2.** based on work introduced in pr #222 (with updates for current veda-backend) ### Source issue NASA-IMPACT/veda-architecture#305 ## How tested - [x] deployed a test stack with cloudfront & browser - [x] pre-deploy cdk diff looks good (runner builds stac-browser) - [x] tested custom domain case (i.e. `<stage>-stac.delta-backend.com`)
smohiudd
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What