Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate necessary components and logic from old map dir to new map dir #888

Closed
sandrahoang686 opened this issue Mar 14, 2024 · 4 comments
Closed
Assignees

Comments

@sandrahoang686
Copy link
Collaborator

sandrahoang686 commented Mar 14, 2024

We need to migrate necessary components from the old map directory /common/mapbox/ to the new map directory /common/map/ so we can get ready to deprecate the old map component.

This task is a follow up after this PR here

Things to consider:

  • Clean up by deleting files and components no longer in use
  • Think about rearranging the files and components to be more re-useable
@aboydnw
Copy link
Contributor

aboydnw commented May 10, 2024

@sandrahoang686 can you help me understand how important this is? Should be part of the VEDA refactor work?

@sandrahoang686
Copy link
Collaborator Author

sandrahoang686 commented May 10, 2024

@aboydnw this is tied to #827. Which actually would be a blocker for veda refactor work of the map component #899. this ticket specifically is really just clean up and moving logic that currently sits with the old map component over to the new so it could be a part of the refactor work or done in iterations. We are gonna have to finish up and close that PR though because it is intertwined.

@dzole0311
Copy link
Contributor

dzole0311 commented May 23, 2024

I migrated a few things through 962, but I think this issue is an ongoing work that will be completed once we fully move away from the old Map component. What's left are the Scrollytelling (967) and the Data Analysis) (969)

@aboydnw
Copy link
Contributor

aboydnw commented Jul 8, 2024

@dzole0311 I see those linked tickets above are closed, does that mean we can close this ticket?

@aboydnw aboydnw closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants