Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Mapbox component to the new Map component in Exploration page #969

Closed
1 task
hanbyul-here opened this issue May 21, 2024 · 6 comments
Closed
1 task
Assignees
Labels
veda v2 VEDA Refactor Epic Work

Comments

@hanbyul-here
Copy link
Collaborator

hanbyul-here commented May 21, 2024

Context

This is a part of #712 , continued work of #827

As we move forward to allowing multiple 'views' for datasets, we decided not to deprecate the current explore view. Therefore this page needs to re-writen to use the new map component so we don't have to keep two map components.

Relates to the original exploration view that can be seen in earthdata.nasa.gov/dashboard

Acceptance Criteria

Related Tickets

#712

@hanbyul-here
Copy link
Collaborator Author

This is not necessarily a blocker, but it will be nice if we can get to this ticket before ArcGIS layer: #943 so we have to touch only one component instead of putting almost duplicated components for both old map and new map.

@hanbyul-here
Copy link
Collaborator Author

We are trying to use new E&A-specific Types and structures for other parts of the application, which results in unnecessary overhead and typecasting. This is the daigram that we came up with to have new Type and data fetching process.

Screen Shot 2024-05-31 at 9 30 14 AM

@sandrahoang686
Copy link
Collaborator

@hanbyul-here thanks for the update and diagram, so is the goal to eventually migrate what is currently using these old timeline related datatypes to the new ones to be created where we aiming for them be more extensible and better defined for more usecases?

@hanbyul-here
Copy link
Collaborator Author

The diagram is to express the need for an explicit data type when the data does not require analysis capacity (Basically all the map-related components not on the E&A page) : like this one: https://github.com/NASA-IMPACT/veda-ui/pull/988/files#diff-a84645a045108f129bae11ffbb6d29f9b1c8744ae7a4f63b4db872211394889bR122 and use timeline datasets only for the Exploration page.

@sandrahoang686
Copy link
Collaborator

@hanbyul-here yep, that makes sense

@hanbyul-here
Copy link
Collaborator Author

I am closing this issue since #840 will totally deprecate the current Explore page, and it is not worth putting more effort into it.

I tried to decrease the duplicated efforts in #991 , by only focusing on the new E&A page for the ArcGIS layers.
Unless it is a change that needs to go out immediately, I think other layers can follow the same pattern to decrease the duplicated work - make them work only with the new E&A page, which uses our new map component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
veda v2 VEDA Refactor Epic Work
Projects
None yet
Development

No branches or pull requests

2 participants