Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Mapbox component to the new Map component in ScrollyMap component #967

Closed
1 task
hanbyul-here opened this issue May 21, 2024 · 1 comment
Closed
1 task

Replace Mapbox component to the new Map component in ScrollyMap component #967

hanbyul-here opened this issue May 21, 2024 · 1 comment
Assignees
@dzole0311
Labels
veda v2 VEDA Refactor Epic Work

Comments

@hanbyul-here
Copy link
Collaborator

hanbyul-here commented May 21, 2024 •
edited
Loading

Context

This is a part of #712 , continued work of #827

Acceptance Criteria

  • Scrolly Map uses new map component

Related Tickets

#712
@hanbyul-here hanbyul-here mentioned this issue May 21, 2024
Open
1 task
@dzole0311 dzole0311 mentioned this issue May 23, 2024
Closed
@aboydnw aboydnw added the veda v2 VEDA Refactor Epic Work label May 23, 2024
@hanbyul-here
Copy link
Collaborator Author

Same with #969, This is not necessarily a blocker, but it will be nice if we can get to this ticket before ArcGIS layer: #943 so we have to touch only one component instead of putting almost duplicated components for both old map and new map.

@hanbyul-here hanbyul-here mentioned this issue May 31, 2024
Closed
@dzole0311 dzole0311 self-assigned this Jun 3, 2024
This was referenced Jun 10, 2024
Merged
Merged
dzole0311 added a commit that referenced this issue Jun 14, 2024
@dzole0311
Replace legacy Mapbox component for Scrollytelling (#992)
abba986 
**Related Ticket:**
[967](#967)

### Description of Changes

This PR replaces the old Map component with the new Map component for
the Scrollytelling block:
https://deploy-preview-992--veda-ui.netlify.app/stories/air-quality-and-covid-19

Changes:

1. Re-factored the Scrollytelling block component to work with the new
`Map` and the `<Layer />` components
2. Deprecated `useAsyncLayers` in favor of using
`useReconcileWithStacMetadata`
3. Removed obsolete code and adjusted some of the types (ie.
`TimelineDatasetStatus` became `DatasetStatus` as I feel we could keep
this more generic, added aliases)
 
### Notes & Questions About Changes


### Validation / Testing
_{Update with info on what can be manually validated in the Deploy
Preview link for example "Validate style updates to selection modal do
NOT affect cards"}_
@hanbyul-here hanbyul-here mentioned this issue Jun 18, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dzole0311 dzole0311

Labels
veda v2 VEDA Refactor Epic Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hanbyul-here @dzole0311 @aboydnw