New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add suffix props for RasterTimeseries component #543
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@hanbyul-here Can you share an example of where the problem was happening? |
The bug can be observed through any scrollymap component. Ex. Scrolly map component on this discovery failing to load the first layer: https://www.earthdata.nasa.gov/dashboard/discoveries/fire-life-cycle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works as a quick fix to get the stories working again. 👍
The suffix also needs to be include in the unmount useEffect
.
However this makes the layer component and the generatorId
prop a bit confusing. Could you open an issue where you detail the problem, explain what the fix does and what could be next steps? I think we should clean this tech debt as soon as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed the dependency in the unmount useEffect
@danielfdsilva Yeah I can make a follow-up ticket but can you elaborate on how this makes |
@hanbyul-here hmm, I think the vector should also have the suffix. For now we don't have them in the scrolly, but they could be there. The |
This PR is ready @danielfdsilva |
Closes #542
This PR is a quick fix to add suffixes to rastetimeseris component for Scrollymap component. We would need a way of generating unique IDs if we are moving forward in the direction of displaying multiple layers simultaneously in the future. I feel like that is an overengineering at this moment so here is a quick fix.