Adding a representation of confined groundwater dynamics into Noah MP 4.0.1

[sshatanawi]

Description

Sawsan’s Simulation (SawSim): We are adding a representation of confined groundwater to the Noah Multi-Parameterization land surface model (Noah MP; Niu et al., 2011; Yang et al.,2011). We developed a new scheme to simulate groundwater dynamics in a three-dimensional system containing two fixed thickness groundwater layers. The first layer acts as an unconfined layer and the second layer acts as a confined aquifer. The scheme simulates vertical and lateral flow from the upper soil layers through a confining unit to the second layer. Lateral groundwater-river exchange is based on head gradients between the groundwater head and river level. The impact of pumping on groundwater dynamics from any of the layers will be simulated. We adopted MODFLOW principles to solve the groundwater flow equation numerically using a finite difference method with the Preconditioned Conjugate Gradient (PCG) solver using PETSc libraries (Balay et al., 1998).
Resolves #1561

Testcase

The test case for now is based on a synthetic scenario where all parameters are homogeneous (constant values)

[dmocko]

Hi @sshatanawi

This PR has been labeled as a "Draft" because the only file change is the creation the "SawSim" sub-directory.

Do you have more code that you expect to include in this PR? What is the timeline for this code to be added?

Please note that as this a new feature to LIS, we will need a testcase for us to fully test the code before it is accepted:
https://nasa-lis.github.io/LISF/howto_create_lis_testcases/howto_create_lis_testcases.html

Further, you will want to submit your code from a separate branch instead of your master branch. Please see instructions
on how to add a "feature" branch from Step 5a (Section 4.7.4) in our Working with GitHub guide:
https://nasa-lis.github.io/LISF/working_with_github/working_with_github.html

You likely will want to do this from a clean directory, and then copy over your changed files for this PR after you create the feature branch.

Finally, can you please let us know which LIS team member you are working with on this groundwater scheme?

[sshatanawi]

Hi, I need more time to modify the new groundwater feature and check the test case. Once I have everything done, I will reply with the information and follow the steps you requested. Thank you, Sawsan

…

On Fri, Oct 11, 2024 at 10:15 AM David Mocko ***@***.***> wrote: Hi @sshatanawi <https://github.com/sshatanawi> This PR has been labeled as a "Draft" because the only file change is the creation the "SawSim" sub-directory. Do you have more code that you expect to include in this PR? What is the timeline for this code to be added? Please note that as this a new feature to LIS, we will need a testcase for us to fully test the code before it is accepted: https://nasa-lis.github.io/LISF/howto_create_lis_testcases/howto_create_lis_testcases.html Further, you will want to submit your code from a separate branch instead of your master branch. Please see instructions on how to add a "feature" branch from Step 5a (Section 4.7.4) in our Working with GitHub guide: https://nasa-lis.github.io/LISF/working_with_github/working_with_github.html You likely will want to do this from a clean directory, and then copy over your changed files for this PR after you create the feature branch. Finally, can you please let us know which LIS team member you are working with on this groundwater scheme? — Reply to this email directly, view it on GitHub <#1562 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVKV6A47CGZSPHZQ6MTJQL3Z3ABTZAVCNFSM6AAAAABJ2XXBCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBXHAZDKNZWGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>