Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the HyMAP2 offline capability, disables HyMAP1 #966

Merged
merged 4 commits into from
Jan 13, 2022

Conversation

sujayvkumar
Copy link
Contributor

Allows HyMAP2 to run based on existing LIS outputs. Currently the capability
only works if the LIS outputs are written in NetCDF format with a '2d gridspace' option

Resolves #965

Description

Replace this text with a concise description of what was changed and why.

Testcase

Allows HyMAP2 to run based on existing LIS outputs. Currently the capability
only works if the LIS outputs are written in NetCDF format with a '2d gridspace' option

Resolves NASA-LIS#965
@sujayvkumar
Copy link
Contributor Author

An example test case is at : /discover/nobackup/svkumar/LISF_testing/966

@bmcandr bmcandr self-requested a review January 12, 2022 18:58
@bmcandr bmcandr added the enhancement New feature or request label Jan 12, 2022
@bmcandr
Copy link
Contributor

bmcandr commented Jan 12, 2022

Hi @sujayvkumar, can this run in parallel? I'm hitting a seg fault when running with the 16 processors listed in your lis.config and lis.job. Your lislog.0000 indicates that particular run was performed with a single processor, while the remaining log files seem to be from a different parallel run.

HyMAP router (older version) is now turned off

Related to NASA-LIS#966
@sujayvkumar
Copy link
Contributor Author

@bmcandr : I just added another fix - Essentially had to turn off the older version of HyMAP

Copy link
Contributor

@bmcandr bmcandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sujayvkumar, I've added a question about the change to lis/plugins/LIS_ronffdata_pluginMod.F90.

Otherwise the code looks good and compiles with the Intel 21 and GNU 11 compilers. I also successfully reproduced the target outputs with a parallel run. Once we get that question resolved I'll go ahead and merge.

lis/plugins/LIS_runoffdata_pluginMod.F90 Show resolved Hide resolved
@bmcandr bmcandr merged commit 9023811 into NASA-LIS:master Jan 13, 2022
@bmcandr bmcandr changed the title Adds the H2 offline capability Adds the HyMAP2 offline capability, disables HyMAP1 Mar 7, 2022
zdenkoheyvaert pushed a commit to zdenkoheyvaert/LISF that referenced this pull request Dec 9, 2023
HyMAP router (older version) is now turned off

Related to NASA-LIS#966
zdenkoheyvaert pushed a commit to zdenkoheyvaert/LISF that referenced this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable HyMAP2 to run offline
2 participants