Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Release DOI function to API #79

Closed
jordanpadams opened this issue Sep 24, 2020 · 0 comments
Closed

Add Release DOI function to API #79

jordanpadams opened this issue Sep 24, 2020 · 0 comments
Assignees
Labels

Comments

@jordanpadams
Copy link
Member

No description provided.

@tloubrieu-jpl tloubrieu-jpl added this to the PDS.04 (ends 2020-11-18) milestone Nov 5, 2020
tloubrieu-jpl pushed a commit that referenced this issue Nov 13, 2020
correct mistakes in documentation

Added force flag to POST API for draft/release actions

Force flag allows warnings encountered during a release action to be bypassed.
Resolves #113

Added the format_exceptions() functions to pds_doi_service.api.util

Function reformats a provided list of Exception instances into a JSON-friendly representation.
Refactored the existing API endpoints to utilize the new function for returning Exceptions/Warnings.
Resolves #106

Fixed typo in definition of pds_doi_service.core.input.exceptions.SiteURLNotExistException

Added force flag to release POST endpoint in swagger.yaml

Modified pds_doi_service.core.outputs.osti_web_parser.response_get_parse_osti_xml() to return any errors parsed from the provided XML

Errors are now returned alongside any parsed DOI objects.
All existing usages of this function have been modified to ignore the new return value for now.

Updated swagger.yaml for release endpoint to expect an LID instead of a DOI ID

Added some new expection types for use with the API release endpoint

Added implementation for DOI service API release POST endpoint

Resolves #79

Reworked existing unit tests to utilize unittest.mock.patch() to stub out calls to core actions
Added unit tests for the release endpoint

Updated swagger.yaml definition to utilize lidvid for release POST requests, rather than lid

The lid and vid fields in the DoiRecord and DoiSummary classes have also been combined into a single lidvid field.
References to separate lid and vid in dois_controller.py have been combined to reference lidvid where necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants