Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error and warning message width should match with the rest of the form #125

Closed
tloubrieu-jpl opened this issue Mar 14, 2022 · 2 comments Β· Fixed by #126
Closed

Error and warning message width should match with the rest of the form #125

tloubrieu-jpl opened this issue Mar 14, 2022 · 2 comments Β· Fixed by #126
Assignees
Labels
B12.1 bug Something isn't working s.medium

Comments

@tloubrieu-jpl
Copy link
Member

tloubrieu-jpl commented Mar 14, 2022

πŸ› Describe the bug

See video here with an example of a very wide message

Screen.Recording.2022-03-14.at.10.57.19.AM.mov

πŸ“œ To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

πŸ•΅οΈ Expected behavior

The width of the error or warning box should be aligned with the rest of the form

πŸ“š Version of Software Used

🩺 Test Data / Additional context

🏞Screenshots

πŸ–₯ System Info

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

πŸ¦„ Related requirements

βš™οΈ Engineering Details

@eddiesarevalo
Copy link
Member

@tloubrieu-jpl I'm not sure how you got a super long no break string but I simulated it by hard coding an error with a long string. I added a css style to break the string if it doesn't fit. So it won't show a long div anymore.

@tloubrieu-jpl
Copy link
Member Author

That will be perfect, thanks @eddiesarevalo.

eddiesarevalo added a commit that referenced this issue Mar 22, 2022
-Added an overflow styling for error messages to prevent showing an oversized div.
tloubrieu-jpl pushed a commit that referenced this issue Mar 25, 2022
* Fix Identifier Typo In DOI Submit #124

-Fixed identifer to identifier.

* Added Overflow Wrap For Long Error Messages #125

-Added an overflow styling for error messages to prevent showing an oversized div.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B12.1 bug Something isn't working s.medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants