Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback says (CORS) error but submits #18

Closed
c-suh opened this issue Aug 2, 2022 · 23 comments
Closed

Feedback says (CORS) error but submits #18

c-suh opened this issue Aug 2, 2022 · 23 comments

Comments

@c-suh
Copy link
Contributor

c-suh commented Aug 2, 2022

🐛 Describe the bug

On submitting something to the Feedback widget, a message will come up that "There was an error sending your feedback." Opening dev tools shows a CORS error. However, the submission goes through. This has been tested from the ATM site, two SBN PSI sites (https://arcnav.psi.edu/ and https://sbn.psi.edu/pds/) and the PDS gamma site.

Notes:

📜 To Reproduce

Steps to reproduce the behavior:

  1. Go to pds.nasa.gov
  2. Click on "Need Help?" to open the Feedback modal
  3. Fill in with your information, indicate it's for testing, and submit
  4. See error

🕵️ Expected behavior

Either the submission should not go through, or the feedback widget should give the "Thank you for making PDS a better site" message.

📚 Version of Software Used

v1.3.0, at least on gamma

🩺 Test Data / Additional context

🏞Screenshots

image

🖥 System Info

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

🦄 Related requirements

⚙️ Engineering Details

@c-suh c-suh added bug Something isn't working needs:triage labels Aug 2, 2022
@c-suh c-suh self-assigned this Aug 2, 2022
@jimmie
Copy link
Member

jimmie commented Aug 4, 2022

Ticket DSIO-2392 opened.

@c-suh
Copy link
Contributor Author

c-suh commented Aug 4, 2022

Sent email to @viviant100 with updates. This is going in the to-do list for me to do after the swagger-ui related task.

@c-suh c-suh removed their assignment Sep 27, 2022
@acyu
Copy link

acyu commented Sep 27, 2022

I am unable to replicate this issue in Chrome. My version of Chrome is Version 105.0.5195.127. Perhaps this is a browser related issue? Will try with different browser
image

@c-suh
Copy link
Contributor Author

c-suh commented Sep 29, 2022

Both Allan and I are not able to replicate this issue (although I encountered it at the time this issue was opened). However, Colleen and a PDS user are still encountering the error message while the feedback submission goes through. Further investigation is again paused while addressing other tasks.

@jordanpadams
Copy link
Member

@c-suh we should try to get a better understanding of the specific browser and version they are using.

@jordanpadams
Copy link
Member

@c-suh FYI, just submitted feedback fine through the RMS widget.

@jordanpadams
Copy link
Member

@c-suh adding this back to the sprint backlog since it has reared its head again

@c-suh
Copy link
Contributor Author

c-suh commented Jul 13, 2023

I am getting reacquainted with the details of this bug. Thus far, this is an issue on the nodes' websites which have the feedback widget installed. I just noticed the ticket linked by Jimmie above, and I think we need to continue that conversation. There's an issue with submitting from the pds-engineering site as well, but it's TBD if it's the same or a different issue.

@c-suh
Copy link
Contributor Author

c-suh commented Jul 13, 2023

Talked with Thomas. Have reopened DSIO-2392 with the SAs with a request.

@c-suh
Copy link
Contributor Author

c-suh commented Jul 18, 2023

Still waiting to hear back from the SAs.

@nutjob4life
Copy link
Member

nutjob4life commented Jul 25, 2023

Ticket comment did not reopen it. Have let SAs know directly.

@c-suh
Copy link
Contributor Author

c-suh commented Jul 27, 2023

Talked with a SA who requested I open a new ticket: DSIO-4244.

@c-suh
Copy link
Contributor Author

c-suh commented Aug 1, 2023

SA has provided new information which I must look at.

@tloubrieu-jpl tloubrieu-jpl self-assigned this Aug 22, 2023
@tloubrieu-jpl
Copy link
Member

For SBN the error is related to the recapcha service not being accessible:
https://voight.psi.edu/recaptcha-v3-verify.php.

The CORS headers have been added to the cloudfront function but this is not working. A ticket DSIO-2392 with the SAs has been reopened to investigate a possible conflict with a response header policy.

@jordanpadams jordanpadams added B14.1 and removed B14.0 labels Oct 9, 2023
@jordanpadams
Copy link
Member

Note: Additional weirdness from https://pds.nasa.gov/tools/doi/#/search. When you try to submit feedback, the email says it is coming from pds-gamma.jpl.nasa.gov.

@matthewtiscareno
Copy link

The feedback button is still broken on the RMS website.

@tloubrieu-jpl
Copy link
Member

Yes, sorry @matthewtiscareno we have been pulled away from that ticket because of other priorities. It is still in my to do list.

@tloubrieu-jpl
Copy link
Member

Something needs to be done.

@tloubrieu-jpl
Copy link
Member

The CORS errors have been fixed by updating the cloudfront function which did not work as needed before.

All the feedbck widgets deployed (ENG, RMS, SBN) now work expect ATM which have a different error related to the recapcha verification, saying I am a bot.

@tloubrieu-jpl
Copy link
Member

tloubrieu-jpl commented Jan 13, 2024

A new ticket has been created for the recaptcha error, see #20

@tloubrieu-jpl
Copy link
Member

The code is not saved on github but is deployed as a cloud front function add_cors_header.

@gxtchen
Copy link

gxtchen commented Mar 18, 2024

@tloubrieu-jpl I am still seeing the error message.

@tloubrieu-jpl
Copy link
Member

Hi @gxtchen , that is correct, I am reproducing that. I need to re-investigate that... Can you open a new ticket with the tag i&t and assign it to me ? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏁 Done
Development

No branches or pull requests

8 participants