Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCB-339: add Units_of_Power with SI watts as option #443

Closed
jshughes opened this issue Feb 23, 2022 · 2 comments · Fixed by #457 or #461
Closed

CCB-339: add Units_of_Power with SI watts as option #443

jshughes opened this issue Feb 23, 2022 · 2 comments · Fixed by #457 or #461
Assignees
Labels
B12.1 p.must-have pending-scr Approved SCR queued for implementation requirement

Comments

@jshughes
Copy link
Collaborator

https://pds-jira.jpl.nasa.gov/browse/CCB-339

CCB-339 add Units_of_Power with SI watts as option

Add Units_of_Power as a new subclass of Unit_of_Measure. Available values for <unit_id> would be [,prefix]watt and dBm (dB with respect to one milliwatt).

@rchenatjpl
Copy link

rchenatjpl commented Mar 19, 2022

@jshughes: PDS4_PDS_1I00.sch has two bugs regarding this.

  1. Line 528 is
    sch:rule context="DD_Value_Domain/pds:unit_of_measure_type" role="warning"
    but should be
    sch:rule context="pds:DD_Value_Domain/pds:unit_of_measure_type" role="warning"
  2. Lines 532,534,588,590 are missing 'Units_of_Power'

The attached badtype.xml's line 30 has unit_of_measure_type = thisshouldnotpassbutdoes, but it passes validate due to the first bug. If you fix that bug but not the second, the attached shouldpass.xml fails validate because lines 30 and 43 have unit_of_measure_type = Units_of_Power
Archive.zip

@rchenatjpl rchenatjpl reopened this Mar 19, 2022
jshughes pushed a commit that referenced this issue Mar 24, 2022
CCB-339	add Units_of_Power with SI watts as option - Bugfix

@rchenatjpl Fixed the following
1.	Line 528 is
sch:rule context="DD_Value_Domain/pds:unit_of_measure_type" role="warning"
but should be
sch:rule context="pds:DD_Value_Domain/pds:unit_of_measure_type" role="warning"
2.	Lines 532,534,588,590 are missing 'Units_of_Power'

https://pds-jira.jpl.nasa.gov/browse/CCB-339

Add Units_of_Power as a new subclass of Unit_of_Measure. Available values for <unit_id> would be [,prefix]watt and dBm (dB with respect to one milliwatt).

Resolves #443
Refs CCB-339
jshughes added a commit that referenced this issue Mar 24, 2022
CCB-339	add Units_of_Power with SI watts as option - Bugfix

@rchenatjpl Fixed the following
1.	Line 528 is
sch:rule context="DD_Value_Domain/pds:unit_of_measure_type" role="warning"
but should be
sch:rule context="pds:DD_Value_Domain/pds:unit_of_measure_type" role="warning"
2.	Lines 532,534,588,590 are missing 'Units_of_Power'

https://pds-jira.jpl.nasa.gov/browse/CCB-339

Add Units_of_Power as a new subclass of Unit_of_Measure. Available values for <unit_id> would be [,prefix]watt and dBm (dB with respect to one milliwatt).

Resolves #443
Refs CCB-339

Co-authored-by: John Hughes <jsh416@gmail.com>
jshughes added a commit that referenced this issue Apr 11, 2022
CCB-339	add Units_of_Power with SI watts as option - Bugfix

@rchenatjpl Fixed the following
1.	Line 528 is
sch:rule context="DD_Value_Domain/pds:unit_of_measure_type" role="warning"
but should be
sch:rule context="pds:DD_Value_Domain/pds:unit_of_measure_type" role="warning"
2.	Lines 532,534,588,590 are missing 'Units_of_Power'

https://pds-jira.jpl.nasa.gov/browse/CCB-339

Add Units_of_Power as a new subclass of Unit_of_Measure. Available values for <unit_id> would be [,prefix]watt and dBm (dB with respect to one milliwatt).

Resolves #443
Refs CCB-339

Co-authored-by: John Hughes <jsh416@gmail.com>
@jpl-jengelke
Copy link
Contributor

testdata.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B12.1 p.must-have pending-scr Approved SCR queued for implementation requirement
Projects
None yet
5 participants