Code refactoring to initialize all singletons and static objects #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numerous objects and data structures throughout the code are initialized within the parent class, but not in the class initialization methods. This would lead to an infinite loop when trying to call the software >1 in the same execution workflow. This fix includes: * Re-init of all global variables in classes where identified * Refactor of DMDocument.main to support the ability to run the software without encountering System.exit() * Add slf4j for future logging capabilities Resolves #801
jshughes
reviewed
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numerous objects and data structures throughout the code are initialized within the parent class, but not in the class initialization methods. This would lead to an infinite loop when trying to call the software >1 in the same execution workflow.
This fix includes:
Resolves #801