Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNAPSHOT dependencies in 2.0.0 release #40

Closed
markBowman opened this issue Apr 28, 2021 · 5 comments
Closed

SNAPSHOT dependencies in 2.0.0 release #40

markBowman opened this issue Apr 28, 2021 · 5 comments
Assignees
Labels
B12.0 bug Something isn't working icebox s.low

Comments

@markBowman
Copy link

The 2.0.0 release of pds4-jparser contains SNAPSHOT dependencies in its pom.xml. This means that this release can not be built using publicly accessible maven repositories. More importantly, downstream projects that depend on pds4-jparsers:2.0.0 also can not be built using public maven repositories. For example, the current master branch of https://github.com/NASA-PDS/validate.
The two SNAPSHOT dependencies are gov.nasa.jpl.ammos.ids.vicario:vicario:48.0.3-SNAPSHOT and com.opencsv:opencsv:5-4-SNAPSHOT.

Potential fix: Release pds4-jparser:2.0.1 with no SNAPSHOT dependencies.

@markBowman markBowman added bug Something isn't working needs:triage labels Apr 28, 2021
@jordanpadams
Copy link
Member

@markBowman thanks for reaching out here. unfortunately, right now those SNAPSHOTS need to stay in there because they are forks of projects that we don't currently own. we will look to get those released to maven central down the road.

once workaround for this would be to do what we do in our POMs:

  1. copy the directory we have in pds4-jparser to your project basedir
  2. update your POM to look for the local "maven repo" to find the SNAPSHOTs:
  <repositories>
    <repository>
      <id>project.local</id>
      <name>project</name>
      <url>file:${project.basedir}/repo</url>
    </repository>
  </repositories>

obviously not an ideal solution, but a workaround at least

@tdddblog
Copy link

@jordanpadams The issue remains in version 2.0.2. Instead of those hacks with copying directories, can we rename custom opencsv and vicario to opencsv-pds and vicario-pds and don't use snapshots.

@jordanpadams
Copy link
Member

@tdddblog can you test using the 2.1.0-SNAPSHOT version of pds4-jparser? i deployed SNAPSHOT versions of the JARs to maven central, so they should be picked up now. you will just need to add snapshots to your list of repositories.

  <repositories>
    <repository>
      <id>snapshots-repo</id>
      <url>https://oss.sonatype.org/content/repositories/snapshots</url>
      <releases>
        <enabled>false</enabled>
      </releases>
      <snapshots>
        <enabled>true</enabled>
      </snapshots>
    </repository>
  </repositories>

@markBowman let me know if this will work for the time being. i can work to tag a relaese, but it is a little more complicated when dealing with maven central

jordanpadams added a commit to NASA-PDS/validate that referenced this issue Jun 16, 2021
Per the use of the opencsv and vicario snapshots, these are now deployed to the maven central snapshots repo.

refs NASA-PDS/pds4-jparser#40
@jordanpadams
Copy link
Member

@markBowman this should now be fixed in the latest version of pds4-jparser

@markBowman
Copy link
Author

@markBowman this should now be fixed in the latest version of pds4-jparser

Thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B12.0 bug Something isn't working icebox s.low
Projects
None yet
Development

No branches or pull requests

3 participants