Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate -f and -m flags #23

Closed
jordanpadams opened this issue Jun 25, 2019 · 6 comments · Fixed by #59
Closed

Deprecate -f and -m flags #23

jordanpadams opened this issue Jun 25, 2019 · 6 comments · Fixed by #59
Assignees
Labels
enhancement New feature or request

Comments

@jordanpadams
Copy link
Member

These flags are no longer applicable to Validate Tool. The label itself should be self-validating, and schema/schematron versions should be specified by the labels themselves, not by validate tool.

@msbentley
Copy link

Does this mean that when validating a collection/bundle labels with different IM versions, products will be validated correctly against the version in each label?

@jordanpadams
Copy link
Member Author

jordanpadams commented Jun 27, 2019 via email

@hhlee445
Copy link
Contributor

hhlee445 commented Jul 9, 2019

@ @galenatjpl Is there any sample label(s) to use for the validate tool?

@hhlee445
Copy link
Contributor

Deprecated -f and -m flags and added a note to use '-x' and/or '-S' flags when it fails in default mode.

@jordanpadams
Copy link
Member Author

@hhlee445 excellent! can we make sure we get a PR created for this? looks like the changes are still just in your branch.

@hhlee445
Copy link
Contributor

hhlee445 commented Jul 17, 2019 via email

jordanpadams added a commit that referenced this issue Jul 25, 2019
Keep flags for now to ensure we don't break existing pipelines, but add
deprecation warning message to output report.
jordanpadams pushed a commit that referenced this issue Jul 25, 2019
* issue_23 Re-deliver issue_23 due to merge conflicts

* Issue #23: Add deprecation message to -f and -m flags

Keep flags for now to ensure we don't break existing pipelines, but add
deprecation warning message to output report.

* Add deprecated warning to config usage
@jordanpadams jordanpadams added the enhancement New feature or request label Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants