Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pds4 version mismatch warning message and problem type #373

Closed
jordanpadams opened this issue Jul 17, 2021 · 1 comment
Closed

Update pds4 version mismatch warning message and problem type #373

jordanpadams opened this issue Jul 17, 2021 · 1 comment
Assignees
@qchaupds
Labels
B12.0 enhancement New feature or request
Milestone
12.Roger.Bannister

Comments

@jordanpadams
Copy link
Member

Describe improvement

Current version mismatch warning message refers to an info message:

  PASS: gov.nasa.pds.validate.ValidateLauncher
      WARNING  [info.validation.general]   Multiple versions (2) of Information Model (IM) found in this run: [1.10.1.0, 1.11.0.0] for rule pds4.bundle
        11 integrity check(s) completed

This should instead be a new warning problem type warning.integrity.pds4_version_mismatch
@jordanpadams jordanpadams added B12.0 enhancement New feature or request labels Jul 17, 2021
@jordanpadams jordanpadams added this to the 12.Roger.Bannister milestone Jul 17, 2021
qchaupds pushed a commit that referenced this issue Aug 4, 2021
Update pds4 version mismatch warning message and problem type
4deab33 
1. Add test resource :src/test/resources/github373 (Must exist directory due to quirkiness with behave)
2. Modify GENERAL_INFO to INTEGRITY_PDS4_VERSION_MISMATCH :src/main/java/gov/nasa/pds/tools/util/LabelUtil.java
3. Add new INTEGRITY_PDS4_VERSION_MISMATCH type :src/main/java/gov/nasa/pds/tools/validate/ProblemType.java
4. Add new INTEGRITY_PDS4_VERSION_MISMATCH type :src/test/java/cucumber/StepDefs.java
5. Add new test for github373 :src/test/resources/features/validate.feature

Refs:

#373 Update pds4 version mismatch warning message and problem type
@qchaupds qchaupds mentioned this issue Aug 4, 2021
Merged
jordanpadams added a commit that referenced this issue Aug 7, 2021
@jordanpadams
Merge pull request #386 from NASA-PDS/#373
6df66dd 
Update pds4 version mismatch warning message and problem type
@jordanpadams
Copy link
Member Author

closed per #386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qchaupds qchaupds

Labels
B12.0 enhancement New feature or request
Projects
None yet
Milestone
12.Roger.Bannister
Development

No branches or pull requests
2 participants
@jordanpadams @qchaupds