Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PDF/A check handling to match with similar product checks #374

Closed
jordanpadams opened this issue Jul 17, 2021 · 0 comments · Fixed by #396
Closed

Refactor PDF/A check handling to match with similar product checks #374

jordanpadams opened this issue Jul 17, 2021 · 0 comments · Fixed by #396
Assignees
@qchaupds
Labels
B12.0 enhancement New feature or request
Milestone
13.Abebe.Bikila

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Jul 17, 2021 •
edited

Enhancement details

Unless there a specific reason we are doing it differently, we should update the PDF/A check to the similar logic used for:

🦄 Applicable requirements
@jordanpadams jordanpadams added B12.0 enhancement New feature or request labels Jul 17, 2021
@jordanpadams jordanpadams added this to the 13.Abebe.Bikila milestone Jul 17, 2021
qchaupds pushed a commit that referenced this issue Aug 27, 2021
Refactor PDF/A check handling to match with similar product checks
991374a 
1. Move existing code for PDF validation to newly created function handlePDF() :src/main/java/gov/nasa/pds/tools/validate/rule/pds4/FileReferenceValidationRule.java
2. Add new private variable pdfUtil so it can be reused :src/main/java/gov/nasa/pds/tools/validate/rule/pds4/FileReferenceValidationRule.java

Refs:

#374 Refactor PDF/A check handling to match with similar product checks
@qchaupds qchaupds mentioned this issue Aug 27, 2021
Merged
qchaupds pushed a commit that referenced this issue Aug 30, 2021
Add error handling for when the file name contains spaces
b668ab6 
1. Add error handling for when the file name contains spaces in function validateFileStandardConformity() :src/main/java/gov/nasa/pds/tools/util/PDFUtil.java
2. Modify number of errors from 1 to 2 due to extra error from validateFileStandardConformity() function :src/test/resources/features/validate.feature

Refs:

#374 Refactor PDF/A check handling to match with similar product checks
jordanpadams added a commit that referenced this issue Sep 1, 2021
@jordanpadams
Merge pull request #396 from NASA-PDS/#374
0e9984e 
Refactor PDF/A check handling to match with similar product checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qchaupds qchaupds

Labels
B12.0 enhancement New feature or request
Projects
None yet
Milestone
13.Abebe.Bikila
Development

Successfully merging a pull request may close this issue.

Refactor PDF/A check handling to match with similar product checks NASA-PDS/validate
2 participants
@jordanpadams @qchaupds