Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide the capability to specify multiple locations for pds4.bundle validation #51

Closed
jordanpadams opened this issue Jul 15, 2019 · 1 comment
Closed

Provide the capability to specify multiple locations for pds4.bundle validation #51

jordanpadams opened this issue Jul 15, 2019 · 1 comment
Assignees
@qchaupds
Labels
B11.1 enhancement New feature or request p.could-have
Milestone
PDS.06 (ends 2020...

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Jul 15, 2019 •
edited
Loading

When a bundle is being staged for release, it may be split across 2 separate locations. This new feature will allow a user to specify additional file path(s) for validate to look for data products.

So let's create a new flag:

--alternate_file_paths   This flag will allow for additional paths to be specified when attempting referential integrity validation (pds4.bundle or pds4.collection rules).

For all products we find and validate in the alternate file path, we should output a new WARNING log message that this data should be collocated with the other bundle data.
@jordanpadams jordanpadams added enhancement New feature or request high and removed new-feature-request labels Aug 21, 2019
@jordanpadams jordanpadams changed the title Add capability to specify multiple locations for pds4.bundle validation Provide the capability to specify multiple locations for pds4.bundle validation Aug 21, 2019
@jordanpadams jordanpadams added the requirement New requirements label Aug 21, 2019
@jordanpadams jordanpadams added this to the PDS.13 (ends 2020-03-25) milestone Dec 13, 2019
@jordanpadams jordanpadams removed the requirement New requirements label Jan 10, 2020
@jordanpadams jordanpadams removed this from the PDS.13 (ends 2020-03-25) milestone Mar 14, 2020
@jordanpadams jordanpadams removed the Epic label Sep 28, 2020
qchaupds pushed a commit that referenced this issue Nov 20, 2020
Architecture changes to support issue #51:
6bee016 
1. Add AdditionalTarget.java to allow setting additional paths in RuleContext.java
2. Add setAdditionalTargetInContext to allow the RuleContext to have alternate paths for referential checks to LocationValidator.java
3. Add logger and debug to InMemoryRegistrar.java
4. Add logger and debug to AbstractValidationRule.java
5. Add functions to set/get the additional paths in RuleContext.java
6. Add doValidateLabelsInFolder to perform validation with target as parameter in LabelInFolderRule.java to process default and additional targets.
7. Add logger and debug to RegisterLabelIdentifiers.java
8. Add parsing of additional paths to ValidateLauncher.java
9. Add ALTERNATE_FILE_PATHS to enum Flag.java
10. Add ALTERNATE_FILE_PATHS to options to FlagOptions.java
@qchaupds qchaupds mentioned this issue Nov 20, 2020
Merged
jordanpadams added a commit that referenced this issue Dec 1, 2020
@jordanpadams
Merge pull request #269 from NASA-PDS/#51
a5d6021 
Add support for specifying alternate file paths for bundle validation
@jordanpadams
Copy link
Member Author

closed per #269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qchaupds qchaupds

Labels
B11.1 enhancement New feature or request p.could-have
Projects
None yet
Milestone
PDS.06 (ends 2020-12-17)
Development

No branches or pull requests
5 participants
@jordanpadams @galenatjpl @hhlee445 @tloubrieu-jpl @qchaupds