Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate 2.4.0/3.0.0 fail with NPE/internal error on certain test cases #545

Closed
jpl-jengelke opened this issue Nov 7, 2022 · 3 comments · Fixed by #549
Closed

Validate 2.4.0/3.0.0 fail with NPE/internal error on certain test cases #545

jpl-jengelke opened this issue Nov 7, 2022 · 3 comments · Fixed by #549
Assignees
Labels

Comments

@jpl-jengelke
Copy link
Contributor

🐛 Describe the bug identified during I&T

Execute validate -t testdata/badtype.xml against the linked dataset used to test pds4-im#499. This will yield both an exception and an internal error. (See attached output, Also, please note an earlier SNAPSHOT of Validate 2.4.0 did not yield this error but the current releases do.)

This error only manifests on this test case so far as others currently appear to not yield the error.

🥼 Related Test Case(s)

pds4-im#499

🔁 : Related issues

These may not be proximately related, but the refactoring preceded the report:
#425
#537


➕ Additional Details

Versions: Java 11, Validate 3.0.0 and Validate 2.4.0
Also, both test commands yield errors:
validate -t baddata.xml
validate -t shouldpass.xml

📜 To Reproduce

Steps to reproduce the behavior:
Download dataset:
Execute validate -t baddata.xml to view error.
Execute validate -t shouldpass.xml to view error.

🕵️ Expected behavior

No NPE, no internal error. Validation should proceed to notify user of errors/warnings or pass product.

📚 Version of Software Used

Validate 2.4.0
Validate 3.0.0

🩺 Test Data / Additional context

https://github.com/NASA-PDS/pds4-information-model/files/9952397/testdata.zip

🏞Screenshots

Execution log:
validate-2.4.0-3.0.0-badtype-fail.txt

🖥 System Info

  • OS: Mac OS X 11.7.1
  • java 11.0.3 2019-04-16 LTS
  • Validate 2.4.0 or 3.0.0
  • GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin20)

🦄 Related requirements

⚙️ Engineering Details

@jpl-jengelke
Copy link
Contributor Author

@gxtchen @viviant100

@nutjob4life
Copy link
Member

I wonder if my fix for validate#544 would also solve this 🤔

@viviant100
Copy link

Unfortunately we are still seeing the issue with v3.0.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment