As a user, I want to validate that all context objects specified in observational products are referenced in the parent bundle/collection Reference_List #69
Comments
jordanpadams
changed the title
jordanpadams
added
enhancement
jordanpadams
added
requirement
jordanpadams
modified the milestones:
PDS.08 (ends 2020-01-15),
PDS.09 (ends 2020-01-29)
jordanpadams
modified the milestones:
PDS.09 (ends 2020-01-29),
PDS.10 (ends 2020-02-12)
jordanpadams
modified the milestones:
PDS.10 (ends 2020-02-12),
PDS.11 (ends 2020-02-26)
jordanpadams
modified the milestones:
PDS.11 (ends 2020-02-26),
PDS.12 (ends 2020-03-11)
jordanpadams
changed the title
jordanpadams
added
p.should-have
requirement
|
I haven't fully digested the email discussion, but just to summarise - the intention is that any target which appears in an observational product should be replicated in the parent collection and/or bundle reference list? For other types of contexts products this makes sense (investigation, host etc.) but for targets it could get... messy. Currently I have been assuming that in the PSA we would curate the bundle label reference lists for the primary mission target(s), and not for every single target that we may have observed during a long cruise, or calibration targets etc. I'm not again it, per se, but because we dynamically update our bundle and collection labels with every product ingestion, this would take some database work to implement etc. |
Validate that all context objects specified in labels are referred to…
|
Is this a fail? product_observational references a target not referenced in bundle or collection. validate flags the bundle but not the collection. |
|
It's probably a fail. The revised test has these lid_references to targets: % validate -R pds4.bundle -t val69b PDS Validate Tool Report Configuration: Parameters: Product Level Validation Results PASS: file:/Users/rchen/Desktop/val69b/bundle-vg1-sat-pos-l1coords-1.0.xml PASS: file:/Users/rchen/Desktop/val69b/data-sedr/SEDR_L1.xml PASS: file:/Users/rchen/Desktop/val69b/data-sedr/collection-data-sedr-1.0.xml PDS4 Bundle Level Validation Results PASS: file:/Users/rchen/Desktop/val69b/data-sedr/collection-data-sedr-1.0.xml PASS: file:/Users/rchen/Desktop/val69b/bundle-vg1-sat-pos-l1coords-1.0.xml PASS: file:/Users/rchen/Desktop/val69b/data-sedr/SEDR_L1.xml Summary: 0 error(s) Product Validation Summary: Referential Integrity Check Summary: Message Types: End of Report |
|
@qchaupds @jordanpadams Another probable point of failure: context products all have LIDs urn:::context:..., i.e. look for "context". The attached should generate no warnings or errors. % validate -R pds4.bundle -t val308a |
|
@rchenatjpl created a new ticket to track this at #430 |
previous expected test result was invalid
previous expected test result was invalid
Numerous issues have stemmed from these updates. Revert those and re-implement #69 at a later date using the registry paradigm
Numerous issues have stemmed from these updates. Revert those and re-implement #69 at a later date using the registry paradigm
Motivation
...so that we can enable quality search results when searching at the collection/bundle level
Additional Details
Reverted per #456
All unique context objects specified in observational products must be referenced in the Reference_List of the parent collection and bundle. These context objects are referenced from:
If the the context product is not referenced in the bundle/collection, throw a WARNING message (TBD, this will become an error once it is documented in the Standards Reference).
Acceptance Criteria
Given a bundle with target identified as X
When I perform validation of the bundle (
-R pds4.bundle) with products that have targets X and YThen I expect validate to throw a WARNING that all targets are not specified in the parent bundle
Given a collection J with target identified as X
When I perform validation of the bundle containing collection J (
-R pds4.bundle) with products that have targets X and YThen I expect validate to throw a WARNING that all targets are not specified in the parent collection
Given a collection J with target identified as X
When I perform validation of the bundle containing collection J (
-R pds4.bundle) with products that have targets X and Y with--skip-context-reference-checkflagThen I expect validate to NOT throw a WARNING
Engineering Details
Some background:
Per email chain with @mitchgordon, @lynnneakrase, @rsjoyner, @rchenatjpl , the issue arose regarding specifying numerous targets within a data collection. There were several other alternatives, including specifying the targets in the context collection and specifying a planetary_system instead of the individual targets, however, it was determined the best way to specify targets at the collection/bundle level is to explicitly add all targets to the bundle/collection label Reference_List. This solution should apply across all context objects.
missing_context_referenceinclude in messageDisable with --skip-context-reference-check flag.The text was updated successfully, but these errors were encountered: