Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate and throw error when duplicate LIDs are found in Bundle #81

Closed
galenatjpl opened this issue Aug 28, 2019 · 2 comments
Closed
Labels

Comments

@galenatjpl
Copy link
Contributor

From Ron Joiner:

Howdy,

I ran validate against a Bundle that mistakenly had duplicate product LIDs – which is a big No No. It would be nice if validate checked and reported any duplicates:

<Identification_Area>
<logical_identifier>urn:nasa:pds:excalibur:data</logical_identifier>

RJ

@jordanpadams jordanpadams added enhancement New feature or request triage-needed labels Aug 28, 2019
@jordanpadams jordanpadams changed the title Validate (and warn) that there aren't any duplicate product IDs Validate and throw error when duplicate LIDs are found Aug 28, 2019
@jordanpadams jordanpadams added Epic requirement New requirements labels Oct 23, 2019
@jordanpadams jordanpadams changed the title Validate and throw error when duplicate LIDs are found Validate and throw error when duplicate LIDs are found in Bundle Oct 23, 2019
@jordanpadams jordanpadams removed the Epic label Oct 23, 2019
@jordanpadams jordanpadams removed the requirement New requirements label Jan 10, 2020
@qchaupds
Copy link
Contributor

qchaupds commented Dec 8, 2020

The current code already check for duplicate identifier:

validate -R pds4.bundle --skip-context-validation --skip-content-validation -r report_github81_invalid.json -s json -t src/test/resources/github81/invalid/bundle
_kaguya_derived.xml
{pds-dev3.jpl.nasa.gov}/home/qchau/sandbox/validate 109 % egrep "status|label" report_github81_invalid.json
"label": "file:/home/qchau/sandbox/validate/src/test/resources/github81/invalid/data_spectra/kgrs_calibrated_spectra_per1.xml",
"status": "FAIL",
"label": "file:/home/qchau/sandbox/validate/src/test/resources/github81/invalid/data_spectra/kgrs_calibrated_spectra_per2.xml",
"type": "error.label.duplicate_identifier",

Jordan suggest this test be added to regression tests.

@jordanpadams
Copy link
Member

Closing per comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants