Refactored validate-refs to use new OpenSearch Serverless and registry-common library
#906
Conversation
|
Stuck at a bug that requires validate pom include jakarta. If we are moving validate-refs to harvest (my recommendation because they share a large amount of code via config) then this would be the time to do it. |
|
@al-niessner let's maybe move forward with this adding this JAR, and then we can create a ticket down the road to refactor, as needed. I like this validate-refs being in the same package as validate because users don't want to download or care to download 2 packages to do "validation". But we can climb that tree when we get to it. |
|
@al-niessner also looks like the tests are failing here. |
|
This cannot build until we update registry-common and harvest. Even if it is complete, it cannot work here or in the wild until those repos are updated. Currently, it only works in my deve environment. |
|
@al-niessner I think we have registry-common merged and some data should be in the AWS OpenSearch Serverless. Do we want to get back onto this task? |
|
Sure. Still stuck with the big question of do we move reference checker to harvest since it shares the configuration or make validate artifact dependent on harvest artifact. I still suggest moving reference checker to harvest since it has zero dependencies on validate. I understand the grouping issue. I suggest solving that with a a pseudo artifact that installs many tools in some grouping rather than actually trying to group stuff by use rather than software dependency. |
Moved to using registry-common and harvest for the tools they provide. harvest provides the configuration reader while the registry-common provides the interface to any opensearch. Updated the logic to use the new tools which made the unit tests invalid. Removed all of the unit test code for RI since it is no longer applicable. The logic of RI has remained. What has changed is how the interface to opensearch is used.
jordanpadams
changed the title
validate-refs to use new OpenSearch Serverless and registry-common
jordanpadams
changed the title
validate-refs to use new OpenSearch Serverless and registry-commonvalidate-refs to use new OpenSearch Serverless and registry-common library
🗒️ Summary
Use registry-common for access to opensearch via Java SDK v2
⚙️ Test Data and/or Report
Had to remove the automated RI checks that did not seem to work anyway (they were causing errors but ignored by checkers) because need a mock for registry-common ConnectionFactory and RestClient. Loaded a DB by hand using ref data repository then ran RI. It ran to completion with no unexpected errors.
♻️ Related Issues
Closes #895
Depends on NASA-PDS/registry-common#57