Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New coma continuum models and convert Afrho/Efrho to/from cross-sectional area. #376

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

mkelley
Copy link
Member

@mkelley mkelley commented Jun 12, 2023

Draft coma continuum models: reddened Afρ model (scattered light) + εfρ model (thermal emission).

Also, add methods to Afrho and Efrho to convert to and from cross-sectional area.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (1315915) 77.52% compared to head (05beba4) 76.73%.

Files Patch % Lines
sbpy/activity/dust.py 51.21% 20 Missing ⚠️
sbpy/activity/tests/test_dust.py 56.52% 20 Missing ⚠️
sbpy/spectroscopy/tests/test_coma.py 84.40% 17 Missing ⚠️
sbpy/spectroscopy/coma.py 96.29% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
- Coverage   77.52%   76.73%   -0.80%     
==========================================
  Files          81       83       +2     
  Lines        7096     7366     +270     
==========================================
+ Hits         5501     5652     +151     
- Misses       1595     1714     +119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pep8speaks
Copy link

pep8speaks commented Jan 17, 2024

Hello @mkelley! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 340:80: E501 line too long (84 > 79 characters)
Line 663:80: E501 line too long (84 > 79 characters)
Line 664:80: E501 line too long (84 > 79 characters)

Line 217:80: E501 line too long (88 > 79 characters)
Line 384:80: E501 line too long (82 > 79 characters)

Line 33:80: E501 line too long (80 > 79 characters)
Line 67:80: E501 line too long (83 > 79 characters)
Line 263:80: E501 line too long (86 > 79 characters)

Line 108:80: E501 line too long (87 > 79 characters)
Line 274:80: E501 line too long (84 > 79 characters)
Line 411:80: E501 line too long (86 > 79 characters)
Line 517:80: E501 line too long (82 > 79 characters)
Line 543:80: E501 line too long (85 > 79 characters)
Line 548:80: E501 line too long (85 > 79 characters)

Line 116:80: E501 line too long (86 > 79 characters)

Comment last updated at 2024-01-18 01:21:19 UTC

@mkelley
Copy link
Member Author

mkelley commented Jan 17, 2024

Closes #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants