Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make beacon search specific, remove reference selection #552

Merged
merged 2 commits into from
May 2, 2019

Conversation

talavis
Copy link
Contributor

@talavis talavis commented Apr 30, 2019

Describe the pull request:

  • Bug fix
  • Functional change
  • New feature
  • Code cleanup
  • Build system change
  • Documentation change
  • Language translation

Pull request long description:

The earlier version used the wrong datasetID for searches. The Beacon system currently interprets incorrect datasetIDs as "search in all datasets", ie the old search checked all datasets. An example
is 4-100118858-C-T - earlier both ACpop and SweGen reported it as present, now it is (correctly) absent in ACpop.

The reference selection is also removed from the frontend. It would always contain only one choice (the reference used by the dataset), and led to a <select> element with only one value available.

Finally, a "show example" text has been added, which fills the form with the variant 22-46615880-T-C, which is also used in the browser.

Changes made:

  • The datasetID is now taken from Beacon, allowing correct searches.
  • Reference selection is removed from the frontend.
  • "Show example" "button" added.

@norling norling merged commit 898219c into develop May 2, 2019
@norling norling deleted the feature/beacon-requests branch May 2, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants