-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the beacon breakends #567
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't enforce capital letters in the field name.
The manta data is usually part of another dataset, and the counts from this file shold not override the counts already stored in the db.
91fed50
to
efe8229
Compare
viklund
reviewed
May 23, 2019
viklund
reviewed
May 23, 2019
'mate_start': data['pos'], 'pos': data['mate_start'], | ||
'chrom_id': data['mate_id'], 'mate_id': data['chrom_id']}) | ||
reversed['variant_id'] = '{}-{}-{}-{}'.format(reversed['chrom'], reversed['pos'], reversed['ref'], alt) | ||
# TODO should the `counter` be increased here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so. If it would be counted if both directions were in the vcf file, it should be counted here as well.
viklund
approved these changes
May 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expanded a comment as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
Small fixes to the sql model and the import script for breakends.
Also adds the
--add_reversed_mates
flag to the importer, to make a BND searchable in the beacon by using any of its two chromosome as the "main" one.Changes made:
allele_num
(callCount
) andallele_count
(variantCount
). '' formate_id
."chromosomeStart"
=>chromosomeStart
(don't enforce capitals
)--add_reversed_mates
to importer. Adds one extra row to the db for each BND, representing the same breakend but with its mate encoded as the starting chromosme.Question:
Should a "loop" like this
1 54720 cluster_216 N N[1:54720[
be kept once or twice in the db?