More style changes for pylint #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If get_transcripts can't find the transcript, it will raise an exception and not return anything.
| (r"/api/dataset/(?P<dataset>[^/]+)/(?:version/(?P<ds_version>[^/]+)/)?browser/search/(?P<query>[^/]+)", handlers.Search), | ||
| (r"/api/dataset/(?P<dataset>[^/]+)/(?:version/(?P<ds_version>[^/]+)/)?browser/download/(?P<datatype>[^/]+)/(?P<item>[^/]+)(?:/filter/(?P<filter_type>[^/]+))?", handlers.Download), | ||
| ] | ||
| routes = [(r"/api/dataset/(?P<dataset>[^/]+)/(?:version/(?P<ds_version>[^/]+)/)?browser/gene/(?P<gene>[^/]+)", handlers.GetGene), |
There was a problem hiding this comment.
In this case, I do think the removed whitespaces make the code less readable.
| with db.database.atomic(): | ||
| for i, feature in enumerate(self.features): | ||
| i = 0 |
There was a problem hiding this comment.
What's wrong with enumerate? Isn't it nice not to have to update i explicitly?
There was a problem hiding this comment.
I found that i is used once outside the loop (directly after). Defining i outside the loop is the only way to guarantee that the value is not garbage collected before it's used there.
There was a problem hiding this comment.
Though that specific i=0 is not needed.
MalinAhlberg
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
More style changes for pylint. Pylint will now be used for backend by travis.