Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/coefficient io #39

Merged
merged 4 commits into from
Jan 12, 2017
Merged

Feature/coefficient io #39

merged 4 commits into from
Jan 12, 2017

Conversation

jhamman
Copy link

@jhamman jhamman commented Jan 5, 2017 •
edited
Loading

This PR allows for the reading and writing of coefficients from the pure_regression mode of GARD.

I have tested this with a single precipitation forecast from GEFS and noticed a significant speedup:

cpu time
raw: 3s
pure0 (default configuration): 1224s
pure1 (write coefficients): 925s
pure2 (read coefficients): 4s

I have also tested that pure0, pure1, and pure2 are all bit-for-bit identical.

xref: https://github.com/NCAR/SHARP/pull/86, https://github.com/lizaclark/ncar_realtime/pull/12

cc @gutmann, @andywood

closes #32

@gutmann
Copy link
Member

gutmann commented Jan 12, 2017

Should have done this a while ago...

@gutmann gutmann merged commit 21d99ec into NCAR:develop Jan 12, 2017
@gutmann gutmann deleted the feature/coefficient_io branch January 13, 2017 16:52
@gutmann gutmann mentioned this pull request Jan 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhamman @gutmann