Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wireframe renderer broken with CAM data #2785

Closed
clyne opened this issue Jul 12, 2021 · 0 comments · Fixed by #2807
Closed

Wireframe renderer broken with CAM data #2785

clyne opened this issue Jul 12, 2021 · 0 comments · Fixed by #2807
Assignees
@clyne
Labels
Bug High Regression A bug that did not previously exist in released code
Projects
Release 3.5.0

Comments

@clyne
Copy link
Collaborator

clyne commented Jul 12, 2021

A regression has been introduced that causes the WireFrame renderer to assert.

To reproduce:

  1. Load CAM/AdamPhillips/F2000C5_new120_025/FV_768x1152.bilinear.F2000C5_new120_025.cam.h0.2004-01.nc
  2. Create a wireframe renderer, selected 2D variables, and enable

vapor terminates with:

VAssert(coords.size() == dims.size()) failed in utils.cpp, line 45
Terminated
@clyne clyne added Bug Regression A bug that did not previously exist in released code labels Jul 12, 2021
@sgpearse sgpearse added the High label Jul 13, 2021
@sgpearse sgpearse added this to To do in Release 3.5.0 via automation Jul 13, 2021
clyne added a commit that referenced this issue Jul 14, 2021
@clyne
Fixed #2785 - Wireframe renderer broken with CAM data
9e1d01c
@clyne clyne mentioned this issue Jul 14, 2021
Merged
Release 3.5.0 automation moved this from To do to Done Jul 15, 2021
clyne added a commit that referenced this issue Jul 15, 2021
@clyne
Fixed Issue 2785 - Wireframe renderer broken with CAM data (#2807)
284b628 
* Fixed #2785 - Wireframe renderer broken with CAM data

* clang-format pre-push hook

* Reviewer comments

* Overloaded Iterator begin() methods to support std::vector<double> as
input parameters.

* Added asserts to check for underflow in dims

* clang-format pre-push hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clyne clyne

Labels
Bug High Regression A bug that did not previously exist in released code
Projects
No open projects
Release 3.5.0
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed Issue 2785 - Wireframe renderer broken with CAM data NCAR/VAPOR
2 participants
@clyne @sgpearse