Fixed Issue 2785 - Wireframe renderer broken with CAM data #2807

clyne · 2021-07-14T15:36:22Z

Refactored Grid iterators to use std::array instead of std:vector, making the iterators consistent with the rest of the Grid API

shaomeng

Just a small improvement needed :)

lib/vdc/CurvilinearGrid.cpp

lib/render/ContourRenderer.cpp

input parameters.

clyne added 2 commits July 14, 2021 09:32

Fixed #2785 - Wireframe renderer broken with CAM data

9e1d01c

clang-format pre-push hook

432ce0a

clyne requested review from shaomeng and sgpearse July 14, 2021 15:36

shaomeng reviewed Jul 14, 2021

View reviewed changes

lib/vdc/CurvilinearGrid.cpp Show resolved Hide resolved

Reviewer comments

9c467ee

clyne requested review from shaomeng and StasJ and removed request for sgpearse July 14, 2021 21:30

shaomeng approved these changes Jul 14, 2021

View reviewed changes

lib/vdc/CurvilinearGrid.cpp Outdated Show resolved Hide resolved

StasJ reviewed Jul 14, 2021

View reviewed changes

lib/render/ContourRenderer.cpp Outdated Show resolved Hide resolved

clyne added 3 commits July 14, 2021 17:58

Overloaded Iterator begin() methods to support std::vector<double> as

5c6c128

input parameters.

Added asserts to check for underflow in dims

be27169

clang-format pre-push hook

ea7e1d2

clyne requested a review from StasJ July 15, 2021 00:00

StasJ approved these changes Jul 15, 2021

View reviewed changes

clyne merged commit 284b628 into main Jul 15, 2021

clyne deleted the issue_2785 branch July 15, 2021 03:48

Provide feedback