Fixes 2853 - crash on roms data #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaomeng
approved these changes
Dec 26, 2021
StasJ
approved these changes
Dec 29, 2021
* fix 2944 by adding offset to resampled extents * test * Only reduce maximum extents * clang format * update extents with comment * remove old code * Update dataMgrTools.cpp Co-authored-by: clyne <clyne@ucar.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2853
This PR fixes #2853.
It also makes substantial progress toward #2765 - complete refactoring of grid class. Namely, it overloads the Grid class constructors with versions that use CoordType or DimsType (std::array) instead of std::vector. The only remaining item to complete #2765 would be to remove the overloaded, deprecated methods in Grid.h (and derived classes) that still use std::vector instead of std::array.
Note, this PR will not pass CI testing until #2944 is fixed.
I've opened this PR in draft status. Due to the number of changes, we may want to consider postponing merging this PR until after the 3.6 release.