Fix: testDataMgr doesn't compute grid extents correctly #2957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgpearse
changed the title
clyne
reviewed
Jan 6, 2022
| minExt[i] /= 32.0; | ||
| maxExt[i] /= 32.0; | ||
| } | ||
| for (int i = 0; i < minExt.size(); i++) maxExt[i] = minExt[i] + maxExt[i] / 32.0; |
There was a problem hiding this comment.
If the goal here is to reduce the data size to 1/32 of its original, keeping the original coordinate origin, then what I believe you want is:
maxExt[i] = minExt[i] + (maxExt[i]-minExt[i]) / 32.0
Consider what would happen with the code as implemented if the extents were, for example, -1000 .. 0. (the volume size is unchanged). Or if the original extents were 1,000,000..1,000,010 (the domain grows!).
To center the reduced domain you could do something like;
center = (maxExt + minExt) / 2.0;
width = (maxExt - minExt) / 32.0
minExt = center - (width / 2.0)
maxExt = center + (width / 2.0);
There was a problem hiding this comment.
Got it, that didn't occur to me. Updated with comment that the origin must be maintained.
clyne
approved these changes
Jan 6, 2022
clyne
added a commit
that referenced
this pull request
Jan 6, 2022
* Replace use of std::vector with std::array in DataMgr for compability with Grid class. WIP * WIP * Incremental * clang-format pre-push hook * Merged with main * clang-format pre-push hook * Port to centos * Fixed edge case - grids with dimesions of 1 * clang-format pre-push hook * Fix: testDataMgr doesn't compute grid extents correctly (#2957) * fix 2944 by adding offset to resampled extents * test * Only reduce maximum extents * clang format * update extents with comment * remove old code * Update dataMgrTools.cpp Co-authored-by: clyne <clyne@ucar.edu> Co-authored-by: sgpearse <pearse@ucar.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2944 by reducing the maximum extents after offsetting them by the minimum value. Removes the reduction to the minimum extents which are not needed.
I'm not sure why clang-format is modifying lines 115 through 117.
@clyne Since this fixes an issue that doesn't present itself on main, this PR is targeting your ROMS PR fix, #2943.