Failures converting data to VDC format #3046 #3047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StasJ
reviewed
Feb 22, 2022
There was a problem hiding this comment.
In the case that a variable is defined as both a coord and data var, this PR appears to only keep whichever is defined last. Wouldn’t this lead to situations where the dataset is missing data or worse missing coordinates? Should we prioritize keeping the coordinate data? We could also rename the data variable to say lat_data in this scenario.
|
Yes, this is a problem. This issue has become a can of worms, and I'm not really sure what to do about it. I need to think some more. Converting this PR to a draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #3046
This change prohibits variables from being defined as both coordinate and data variables in the VDC. At present the VDC cannot support this because the underlying NetCDF API doesn't allow a variable to be defined twice.