Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures converting data to VDC format #3046

Closed
clyne opened this issue Feb 22, 2022 · 0 comments · Fixed by #3051
Closed

Failures converting data to VDC format #3046

clyne opened this issue Feb 22, 2022 · 0 comments · Fixed by #3051
Assignees
@clyne
Labels
Bug High
Milestone
3_6_0 Release

Comments

@clyne
Copy link
Collaborator

clyne commented Feb 22, 2022 •
edited by sgpearse

A number of canonical data sets can not be converted to the VDC format with cfvdccreate/cf2vdc:

CAM/AdamPhillips/F2000C5_new120_025
POP/BryanASP/one_degree/daily
POP/BryanASP/one_degree/monthly
POP/BryanASP/tenth_degree/daily
POP/BryanASP/tenth_degree/monthly
ROMS/Kauffman
@clyne clyne added the Bug label Feb 22, 2022
clyne added a commit that referenced this issue Feb 22, 2022
@clyne
Fixed #3046 - Failures converting data to VDC format
ff4790d
@clyne clyne mentioned this issue Feb 22, 2022
Closed
@clyne clyne added the High label Feb 22, 2022
@clyne clyne added this to the 3_6_0 Release milestone Feb 22, 2022
@clyne clyne self-assigned this Feb 22, 2022
clyne added a commit that referenced this issue Feb 23, 2022
@clyne
Fixed #3046 - Failures converting data to VDC format
fa5929b 
VDC library wasn't supporting variables that not compressed, but had
missing values.
@clyne clyne mentioned this issue Feb 23, 2022
Merged
clyne added a commit that referenced this issue Feb 24, 2022
@clyne
Fixed #3046 - Failures converting data to VDC format (#3051)
bbf18a5 
* Changed NetCDFCpp::DefVar to not return an error if the same variable is
defined twice, but with the same definition.

* Fixed #3046 - Failures converting data to VDC format

VDC library wasn't supporting variables that not compressed, but had
missing values.

* clang-format pre-push hook

* Removed newly added, third overloaded version of VDC::DefineDataVar()
The original two were sufficient with some minor logic changes.

* clang-format pre-push hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clyne clyne

Labels
Bug High
Projects
None yet
Milestone
3_6_0 Release
1 participant
@clyne